Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blade: Text is rendered either too thick or too thin #13564

Open
1 task done
apricotbucket28 opened this issue Jun 27, 2024 · 5 comments
Open
1 task done

blade: Text is rendered either too thick or too thin #13564

apricotbucket28 opened this issue Jun 27, 2024 · 5 comments
Labels
bug [core label] font Font feedback for readability, size, style, etc linux linux-wayland Linux Wayland

Comments

@apricotbucket28
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Ever since a89dc8c, text rendering has either been to thick or too thin, depending on the theme.

Screenshots

(they're not mine, I just took them from the Discord channel)

Dark theme

Before
image
After
image

Light theme

Before
image
After
image

Environment

Zed: v0.142.0 (Zed Nightly eb91468)
OS: Linux Wayland fedora 40
Memory: 30.5 GiB
Architecture: x86_64

Since this is an issue with the Blade renderer, I can also reproduce on Windows.

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
@apricotbucket28 apricotbucket28 added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jun 27, 2024
@notpeter notpeter added linux font Font feedback for readability, size, style, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 27, 2024
@notpeter notpeter added the linux-wayland Linux Wayland label Jul 9, 2024
@ajstarks
Copy link

Workaround:
setting "buffer_font_weight": 600 works for light mode themes.

@ciaran-matthew-dunne
Copy link

ciaran-matthew-dunne commented Sep 9, 2024

Following on from #14169, it appears Zed is having issues with font weights. Changing the buffer font weight is ineffective until 600, which also looks badly rendered.

Screenshot from 2024-09-09 17-00-47
Screenshot from 2024-09-09 17-01-01

Zed.log

@landersson
Copy link

Agreed. Font's are way to skinny by default on Linux... With "ui_font_weight": 600, the font is instead too thick and generally looks a bit off.

@github-actions github-actions bot added admin read Pending admin review triage Maintainer needs to classify the issue labels Nov 5, 2024
@notpeter notpeter removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 5, 2024
@donjan
Copy link

donjan commented Dec 3, 2024

Still the case with Zed 0.163.3. I can't make it look as good as other editors (or almost any other application) on Linux.
Image shows VSCode | Zed | Geany:
fonts
Reportedly this might improve if we move to a different text system, as suggested in #13951

@lnicola
Copy link

lnicola commented Dec 3, 2024

I think this is a relatively well-known issue related to linear ("correct") blending of text. I couldn't find a better source, but https://freetype.org/freetype2/docs/hinting/text-rendering-general.html touches on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] font Font feedback for readability, size, style, etc linux linux-wayland Linux Wayland
Projects
None yet
Development

No branches or pull requests

7 participants