Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for GTK theme support in Zed editor #14871

Open
1 task done
millan242 opened this issue Jul 20, 2024 · 6 comments
Open
1 task done

Request for GTK theme support in Zed editor #14871

millan242 opened this issue Jul 20, 2024 · 6 comments
Labels
enhancement [core label] linux theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@millan242
Copy link

Check for existing issues

  • Completed

Describe the feature

It would be beneficial if the Zed editor could support GTK themes to provide a consistent user experience across the desktop environment.

Current Behavior:
Zed editor uses its default theme regardless of the GTK theme applied to the system.

Desired Behavior:
The Zed editor should automatically adopt the system-wide GTK theme, including font settings, window decorations, and color schemes, to ensure visual consistency with other GTK applications.

Use Case:
Many users prefer a unified look and feel for their applications, especially those using GTK-based desktop environments like GNOME and XFCE.

Additional Information:
Operating System: Ubuntu 24.04 LTS x86_64
GTK Theme: WhieSur GTK theme
Zed Editor Version: 0.144.4

If applicable, add mockups / screenshots to help present your vision of the feature

Screenshot from 2024-07-20 22-58-12

@millan242 millan242 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jul 20, 2024
@notpeter notpeter added linux theme Feedback for theme configuration, accessibility, visual issues, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 26, 2024
@apricotbucket28
Copy link
Contributor

Implementing GTK theming would be a difficult task and probably not a good idea (mainly on the technical side). However, adding Freedesktop accent color support would be quite nice.

Here's a good article on the matter: https://cassidyjames.com/blog/freedesktop-accent-colors-gnome-proposal/

From https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Settings.html:

org.freedesktop.appearance accent-color ((ddd))
Indicates the system’s preferred accent color as a tuple of RGB values in the sRGB color space, in the range [0,1]. Out-of-range RGB values should be treated as an unset accent color.

Also want to clarify:

font settings, window decorations

Those are not related to the GTK theme. I'm not sure what you mean by the latter, but the former can be fixed separately.

@LSeelig
Copy link

LSeelig commented Aug 9, 2024

Those are not related to the GTK theme. I'm not sure what you mean by the latter, but the former can be fixed separately.

This refers to the bar at the top of the window, which has different close/minimize/maximize icons and layout from all GTK apps (and soon, QT apps as well). GNOME doesn't even support server-side decorations, so libdecor might be the only solution.

@adityainduraj
Copy link

Just saying, having a Gnome-GTK-ish top bar will go a long way in making Zed feeling much more integrated in the UI.

@olumolu
Copy link

olumolu commented Aug 26, 2024

And make sure use gtk4

@Searge
Copy link

Searge commented Oct 1, 2024

Hello 👋

Any progress/solution?

@Searge
Copy link

Searge commented Oct 1, 2024

Related issue: #14120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] linux theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Development

No branches or pull requests

7 participants