Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing RETURN key on terminal's search input changes focus to the source code editor #16790

Open
1 task done
bmamouri opened this issue Aug 24, 2024 · 1 comment
Open
1 task done
Labels
keymap / key binding Feedback for keyboard shortcuts, key mapping, etc support User support (non-defect troubleshooting, documentation, etc) terminal Feedback for terminal integration, shell commands, etc

Comments

@bmamouri
Copy link

bmamouri commented Aug 24, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When pressing RETURN key on the search input of the terminal, the focus moves to the source code editor. So if you want to change the search phrase you need to move back the cursor into search input of the terminal.

I think once you press the RETURN key, they focus should remain on the search input itself. This is how Jetbrains IDEA and VSCode works too.

Reproduction

  1. Open the terminal
  2. Press Command + F to open the search input
  3. Search for something
  4. Press the RETURN key. You will notice that the focus changes to source code window above terminal window.
image

Environment

Zed: v0.149.5 (Zed)
OS: macOS 14.6.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@bmamouri bmamouri added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Aug 24, 2024
@notpeter
Copy link
Member

I am not able to reproduce this with the default keybindings. (enter correctly jumps to highlighting the next search result).

Do you have anything in your ~/.zed/keymap.json which might be related? If so, could you try commenting out the whole file (cmd-a, cmd-/, cmd-s) and see if the issue persists.

@notpeter notpeter added terminal Feedback for terminal integration, shell commands, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc support User support (non-defect troubleshooting, documentation, etc) and removed bug [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap / key binding Feedback for keyboard shortcuts, key mapping, etc support User support (non-defect troubleshooting, documentation, etc) terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

No branches or pull requests

2 participants