Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when leaving collab channel #21937

Open
1 task done
RemcoSmitsDev opened this issue Dec 12, 2024 · 1 comment
Open
1 task done

Crash when leaving collab channel #21937

RemcoSmitsDev opened this issue Dec 12, 2024 · 1 comment
Labels
bug [core label] collaboration The umbrella label for all collaboration features panic / crash [core label]

Comments

@RemcoSmitsDev
Copy link
Contributor

RemcoSmitsDev commented Dec 12, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

It seems like the crash happens when there are 2 people inside a channel, and the leader and the other participant leave at the same time Zed will crash. I had this crash a couple of times already, so I think I can reproduce this easily.

More context:

  • Most of the time the leader has their screen shared
  • The other participant does not have their screen shared
  • We only have 1 shared project

Crash report

Environment

Zed: v0.167.0 (Zed Nightly 0eb9922)
OS: macOS 15.2.0
Memory: 16 GiB
Architecture: aarch64

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
2024-12-12T21:44:17.613183+01:00 [ERROR] connection error: error reading rpc message from socket

Caused by:
    0: WebSocket protocol error: Connection reset without closing handshake
    1: Connection reset without closing handshake
2024-12-12T21:44:17.614202+01:00 [INFO] set status on client 75390: ConnectionLost
2024-12-12T21:44:17.618005+01:00 [INFO] detected client disconnection
2024-12-12T21:44:17.618588+01:00 [INFO] waiting for client status change, remaining attempts 3
2024-12-12T21:44:17.618872+01:00 [INFO] set status on client 75390: Reauthenticating
2024-12-12T21:44:17.619063+01:00 [INFO] set status on client 75390: Reconnecting
2024-12-12T21:44:17.619807+01:00 [INFO] waiting for client status change, remaining attempts 3
2024-12-12T21:44:17.908784+01:00 [INFO] connected to rpc endpoint https://collab.zed.dev/rpc
2024-12-12T21:44:17.916153+01:00 [ERROR] not connected
2024-12-12T21:44:18.471069+01:00 [INFO] add_connection;
2024-12-12T21:44:18.471543+01:00 [INFO] set status on client 75390: Connected { peer_id: PeerId { owner_id: 625, id: 876459 }, connection_id: ConnectionId { owner_id: 0, id: 1 } }
2024-12-12T21:44:18.47304+01:00 [INFO] client reconnected, attempting to rejoin room
2024-12-12T21:44:18.592453+01:00 [INFO] successfully reconnected to room
2024-12-12T21:44:18.6585+01:00 [INFO] unhandled message SynchronizeContexts
2024-12-12T21:45:31.411431+01:00 [INFO] unhandled message Unfollow
2024-12-12T21:45:54.374466+01:00 [ERROR] unsubscribed from track by unknown participant
@RemcoSmitsDev RemcoSmitsDev added admin read Pending admin review bug [core label] panic / crash [core label] triage Maintainer needs to classify the issue labels Dec 12, 2024
@JosephTLyons JosephTLyons added collaboration The umbrella label for all collaboration features and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 20, 2024
@smithxxl
Copy link

Having the same issue. It seems to correlate with someone disconnecting from the channel. There was no relevant info in the Zed log, however here is the crash report:

Zed_crash_report.txt

Hardware Overview:

Model Name: MacBook Pro
Model Identifier: MacBookPro16,1
Processor Name: 8-Core Intel Core i9
Processor Speed: 2.3 GHz
Number of Processors: 1
Total Number of Cores: 8
L2 Cache (per Core): 256 KB
L3 Cache: 16 MB
Hyper-Threading Technology: Enabled
Memory: 32 GB
System Firmware Version: 2069.40.2.0.0 (iBridge: 22.16.12093.0.0,0)
OS Loader Version: 582~2898

AMD Radeon Pro 5500M 4 GB
Intel UHD Graphics 630 1536 MB

System Software Overview:

System Version: macOS 15.2 (24C101)
Kernel Version: Darwin 24.2.0
Boot Volume: Macintosh HD
Boot Mode: Normal
Secure Virtual Memory: Enabled
System Integrity Protection: Enabled
Time since boot: 6 days, 21 hours, 9 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] collaboration The umbrella label for all collaboration features panic / crash [core label]
Projects
None yet
Development

No branches or pull requests

3 participants