Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain: detect $VIRTUAL_ENV #22021

Closed
1 task done
pantheraleo-7 opened this issue Dec 14, 2024 · 2 comments
Closed
1 task done

Toolchain: detect $VIRTUAL_ENV #22021

pantheraleo-7 opened this issue Dec 14, 2024 · 2 comments
Labels
enhancement [core label] python Python programming language support upstream

Comments

@pantheraleo-7
Copy link
Contributor

pantheraleo-7 commented Dec 14, 2024

Check for existing issues

  • Completed

Describe the feature

It is not very convenient to put a venv on $PATH. Zed should read $VIRTUAL_ENV and show the venv in the toolchain. VS Code does this (when a folder is open).

The use case is that in non-package (library) centric fields, mostly a "global" venv is used rather than per-project basis.

Environment

Zed: v0.166.1 (Zed Preview)
OS: macOS 15.2.0
Memory: 8 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help present your vision of the feature

export VIRTUAL_ENV="$HOME/.local/share/ds"
VS Code:
image

@pantheraleo-7
Copy link
Contributor Author

Seems like VS Code had this venv cached or something from the last time I put it on $PATH. VS Code and Zed both use PET for detection therefore both should be same, as I initially thought, and this is indeed the case.

So this should be added upstream as this is very common and needed (detecting $VIRTUAL_ENV that is).

(in the meantime Zed could add this)

@pantheraleo-7 pantheraleo-7 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2024
@notpeter
Copy link
Member

Here's the issue @pantheraleo-7 opened an issue upstream:

Thanks for reporting.

@notpeter notpeter added python Python programming language support upstream and removed triage labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] python Python programming language support upstream
Projects
None yet
Development

No branches or pull requests

2 participants