Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Vertical tabs #4331

Open
1 task done
bstst opened this issue Nov 24, 2023 · 4 comments
Open
1 task done

Feature request: Vertical tabs #4331

bstst opened this issue Nov 24, 2023 · 4 comments
Labels
design [core label] enhancement [core label] tabs Feedback for tabs behavior, navigation, style, etc

Comments

@bstst
Copy link

bstst commented Nov 24, 2023

Check for existing issues

  • Completed

Describe the feature

I would love to have the ability to switch the tab layout to vertical.

just like JetBrains do. this feature request is somewhat related to #5240, yet it's not a request for a separate pane, only the ability to switch tab layout.

If applicable, add mockups / screenshots to help present your vision of the feature

image

@bstst bstst added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Nov 24, 2023
@JosephTLyons JosephTLyons added tabs Feedback for tabs behavior, navigation, style, etc design [core label] and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 26, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@syntastical
Copy link

Yeah, probably seems trivial to most, but vertical tabs has become a crucial part of my IDE needs.

@omid
Copy link

omid commented Jul 12, 2024

I'm just playing around with the source code to get more familiar with it.
I'm not sure if the zed devs will accept the changes or not, or how generally the process (I've read the CONTRIBUTING file) works? It's not a tiny change, it's also not a big one!

So far, it's like the screenshot below, but it's not resizable, and it's just top or right (and none, to remove one config? and I will try to add left and bottom also).
It's not a pane, it's exactly the same tab_bar we have on top.

Ref: #6667 (comment) (and a bit #5240)

image

PS: the code is not close to ready to be a PR.

@m-czyz
Copy link

m-czyz commented Aug 14, 2024

hey @omid could you somehow share your WIP changes? I would like to contribute to the development of this feature too, but I don't want to start from the scratch

@omid
Copy link

omid commented Aug 15, 2024

@m-czyz sure. But be aware that it's just a PoC.
For example, I completely commented out the top bar, instead of handling it by conditions.
I made a PR here for this branch.

PS: We can remove tab_bar.show config also. And add a None to TabBarPosition enum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design [core label] enhancement [core label] tabs Feedback for tabs behavior, navigation, style, etc
Projects
None yet
Development

No branches or pull requests

5 participants