Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP does not work for nested projects #4574

Open
1 task done
failable opened this issue Jul 30, 2023 · 5 comments
Open
1 task done

LSP does not work for nested projects #4574

failable opened this issue Jul 30, 2023 · 5 comments
Labels
bug [core label] language server An umbrella label for all language servers workspace Feedback for workspace management, layout, interactions, etc

Comments

@failable
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Given the following project structure:

abc
├── .git            # Root here
├── def
|   ├── .venv
│   ├── pyproject.toml
│   ├── pyrightconfig.json
│   └── test.py
└── xyz
    ├── .venv
    ├── pyproject.toml
    ├── pyrightconfig.json
    ├── test2.py

and the content of pyrightconfig.json is

{
  "venv": ".venv",
  "venvPath": "."
}
  1. Open projects by zed abc/def or zed abc/xyz, everything (completion etc.) works fine.
  2. Open root project by zed abc, completion for 3rd library will not work in test.py and test2.py.

Environment

Zed: v0.97.5 (preview)
OS: macOS 13.2.1
Memory: 32 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@failable failable added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jul 30, 2023
@JosephTLyons JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc language server failure Language server doesn't work as expected unsupported language language server An umbrella label for all language servers and removed triage Maintainer needs to classify the issue admin read Pending admin review language server failure Language server doesn't work as expected unsupported language labels Aug 3, 2023
@meguriau
Copy link

meguriau commented Aug 8, 2023

Encountered the same issue, opening many nested folders/projects to by pass the issue is quite inconvenient right now.

@failable
Copy link
Author

failable commented Aug 9, 2023

Today I found a related issue of this. When running the formatter command from the outer workspace, some tools like isort works incorrectly. It failed to recognize config.py.

Open outer folder, isort works incorrectly.
image

Open inner folder, isort works properly.
image

@dlindenkreuz
Copy link

This has interesting network effects with this issue: #5161

With a multi-project setup that has one common Git root, I either have to:

  • open a non-root folder and get LSP support without the Git gutter
  • open the root folder and get the Git gutter without LSP support

… which is pretty frustrating IMO.

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024

This comment was marked as outdated.

@github-actions github-actions bot added the stale Label used by `stale` action label Sep 24, 2024
@failable
Copy link
Author

Still happens in

Zed: v0.154.1 (Zed Preview)
OS: macOS 15.0.0
Memory: 32 GiB
Architecture: x86_64

@github-actions github-actions bot removed the stale Label used by `stale` action label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] language server An umbrella label for all language servers workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

4 participants