Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support Argo Rollouts #430

Open
ghost opened this issue Feb 4, 2022 · 5 comments
Open

Feature request: Support Argo Rollouts #430

ghost opened this issue Feb 4, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 4, 2022

Would be nice to support Argo Rollouts CRD's as deployment type (now this is not recognized as a valid target reference):

For example:

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  name: my-service
spec:
  strategy:
    canary:
      analysis:
        templates:
          - templateName: build-low-error-low-latency
        args:
          - name: service
            value: my-service
          - name: namespace
            value: my-namespace
          - name: build
            value: $(BUILD)
        startingStep: 1
      steps:
        - setWeight: 100
        - pause: {duration: 10m}
@kmarteaux
Copy link
Contributor

@ghost
Copy link
Author

ghost commented Feb 18, 2022

@kmarteaux did not know about that, will try it, many thanks!

@Ayushwiprobflex7239
Copy link

Argo Rollouts has validation rule built in -- see to the same program written by me I have tried my level bes to solve the query

@bitti
Copy link

bitti commented May 27, 2022

The problem is not resolved by the fact that argo has its own linter. The problem is that kube-score gives these false negatives:

    [CRITICAL] Service Targets Pod
        · The services selector does not match any pods

I suppose that's because it doesn't check these selectors against the argo rollout pod template labels?

@bbortt
Copy link

bbortt commented Jul 20, 2022

The services selector does not match any pods

we're experiencing the same problem. would be cool to have this. I don't know anything about the implementation of kube-score itself, so helping is hard. but testing is no problem for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants