Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on the use of livenessProbe #522

Open
binboum opened this issue Mar 10, 2023 · 0 comments
Open

Documentation on the use of livenessProbe #522

binboum opened this issue Mar 10, 2023 · 0 comments

Comments

@binboum
Copy link

binboum commented Mar 10, 2023

Hello :)

We recently used within the company in which I work kube-score in order to improve the quality of our deliverables.

I noticed that on the livenessProbe level documentation : https://github.com/zegl/kube-score/blob/master/README_PROBES.md#livenessprobe

There were these recommendations :

kube-score recommends:

  • If you don't know why you need a livenessProbe, don't configure it.
  • It should never, be the same as your readinessProbe.
  • The livenessProbe should never depend on downstream dependencies, such as databases or other services.

I don't know how the message is interpreted in general.
However, I find this message ambiguous, and in my opinion, It would be a little more educational by encouraging the user to understand his use and it is he who will make the choice knowingly.

I would have preferred a more educational twist like :

image

Here : kubernetes/website#16607 (comment)

PR discussion : kubernetes/website#39930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant