Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSG data request failing with trailing slash #10140

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Fix SSG data request failing with trailing slash #10140

merged 2 commits into from
Jan 17, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 17, 2020

This makes sure to remove the trailing slash before making the data request for an SSG page. It also adds a test to prevent regression

Fixes: #9929

@ijjk ijjk added the Type: Bug label Jan 17, 2020
@ijjk ijjk added this to the 9.2.x milestone Jan 17, 2020
@ijjk
Copy link
Member Author

ijjk commented Jan 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
buildDuration 13.7s 13.9s ⚠️ +200ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +352 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB 13.7 kB ⚠️ +19 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.5 kB ⚠️ +19 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.module.js gzip 4.16 kB 4.16 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ⚠️ +22 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +22 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
index.html gzip 1.02 kB 1.02 kB -1 B
link.html gzip 1.03 kB 1.03 kB -2 B
withRouter.html gzip 1.01 kB 1.01 kB ✓
Overall change 3.07 kB 3.06 kB -3 B

Diffs

Diff for de003c3a9d30..e4.module.js 
@@ -1863,7 +1863,12 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
           this._getStaticData = (asPath, _cachedData) => {
             var pathname = url_1.parse(asPath).pathname
-            pathname = !pathname || pathname === '/' ? '/index' : pathname
+            pathname = !pathname || pathname === '/' ? '/index' : pathname // remove trailing slash from path
+
+            if (pathname.substr(pathname.length - 1) === '/') {
+              pathname = pathname.substr(0, pathname.length - 1)
+            }
+
             return true && (_cachedData = this.sdc[pathname])
               ? _Promise.resolve(_cachedData)
               : fetch(
Diff for de003c3a9d30..0b02858bf.js 
@@ -1529,7 +1529,12 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
             this._getStaticData = function(asPath, _cachedData) {
               var pathname = url_1.parse(asPath).pathname
-              pathname = !pathname || pathname === '/' ? '/index' : pathname
+              pathname = !pathname || pathname === '/' ? '/index' : pathname // remove trailing slash from path
+
+              if (pathname.substr(pathname.length - 1) === '/') {
+                pathname = pathname.substr(0, pathname.length - 1)
+              }
+
               return true && (_cachedData = _this.sdc[pathname])
                 ? _Promise.resolve(_cachedData)
                 : fetch(
Diff for index.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7959f6164207a479d861.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d4f11993933206e5d7c.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7959f6164207a479d861.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7959f6164207a479d861.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -156,13 +156,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d4f11993933206e5d7c.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7959f6164207a479d861.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7959f6164207a479d861.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d4f11993933206e5d7c.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7959f6164207a479d861.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
buildDuration 13.8s 13.8s -74ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +352 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..af9c.js gzip N/A 13.7 kB N/A
Overall change 67.4 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.module.js gzip 4.16 kB 4.16 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 12.5 kB N/A
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_error.js gzip 77.9 kB 78 kB ⚠️ +38 B
hooks.html gzip 1.05 kB 1.05 kB ⚠️ +1 B
index.js gzip 78.1 kB 78.2 kB ⚠️ +42 B
link.js gzip 80.6 kB 80.6 kB ⚠️ +43 B
routerDirect.js gzip 78.2 kB 78.3 kB ⚠️ +39 B
withRouter.js gzip 78.3 kB 78.3 kB ⚠️ +39 B
Overall change 394 kB 394 kB ⚠️ +202 B

Commit: 1224c39

@ijjk
Copy link
Member Author

ijjk commented Jan 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
buildDuration 13.5s 13.5s ✓
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +18 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB 13.7 kB ⚠️ +2 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ⚠️ +2 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.module.js gzip 4.16 kB 4.16 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ⚠️ +3 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
index.html gzip 1.02 kB 1.02 kB -1 B
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.01 kB 1.01 kB ✓
Overall change 3.07 kB 3.06 kB -1 B

Diffs

Diff for de003c3a9d30..e4.module.js 
@@ -1863,7 +1863,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
           this._getStaticData = (asPath, _cachedData) => {
             var pathname = url_1.parse(asPath).pathname
-            pathname = !pathname || pathname === '/' ? '/index' : pathname
+            pathname = toRoute(
+              !pathname || pathname === '/' ? '/index' : pathname
+            )
             return true && (_cachedData = this.sdc[pathname])
               ? _Promise.resolve(_cachedData)
               : fetch(
Diff for de003c3a9d30..0b02858bf.js 
@@ -1529,7 +1529,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
             this._getStaticData = function(asPath, _cachedData) {
               var pathname = url_1.parse(asPath).pathname
-              pathname = !pathname || pathname === '/' ? '/index' : pathname
+              pathname = toRoute(
+                !pathname || pathname === '/' ? '/index' : pathname
+              )
               return true && (_cachedData = _this.sdc[pathname])
                 ? _Promise.resolve(_cachedData)
                 : fetch(
Diff for index.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -156,13 +156,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
buildDuration 13.9s 14.2s ⚠️ +323ms
nodeModulesSize 48.9 MB 48.9 MB ⚠️ +18 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..8249.js gzip N/A 13.7 kB N/A
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
main-HASH.module.js gzip 4.16 kB 4.16 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 12.5 kB N/A
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/ssg-trailing-slash Change
_error.js gzip 77.9 kB 77.9 kB -1 B
hooks.html gzip 1.05 kB 1.05 kB ⚠️ +1 B
index.js gzip 78.1 kB 78.1 kB ⚠️ +1 B
link.js gzip 80.6 kB 80.6 kB ⚠️ +2 B
routerDirect.js gzip 78.2 kB 78.2 kB ⚠️ +1 B
withRouter.js gzip 78.3 kB 78.3 kB ⚠️ +1 B
Overall change 394 kB 394 kB ⚠️ +5 B

Commit: cab730c

Timer
Timer approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Timer Timer modified the milestones: 9.2.x, 9.2.1 Jan 17, 2020
@Timer Timer merged commit 51420c7 into vercel:canary Jan 17, 2020
@Timer Timer deleted the fix/ssg-trailing-slash branch January 17, 2020 16:54
@lucaziz
Copy link

lucaziz commented Jan 17, 2020

Thank you!

@fevernova90
Copy link

fevernova90 commented Feb 1, 2020 •
edited
Loading

I am still experiencing the issue in 9.2.1.

Maybe because I am using custom server with getRequestHandler() and these configurations:

  1. getInitialProps in _app.js and _document.js.
  2. placing my "pages" folder inside "src".

Temporarily fixed this with manual app.render() in my koa routing.

This was referenced Feb 18, 2020
Closed
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.1
4 participants
@ijjk @lucaziz @fevernova90 @Timer