-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for BigInt to API routes #10215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmosier
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
January 22, 2020 19:14
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 12.6s | 12.5s | -86ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.1 kB | 4.1 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | ✓ |
link.html gzip | 1.03 kB | 1.03 kB | ✓ |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 13.4s | 13s | -440ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.1 kB | 4.1 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_error.js gzip | 46.2 kB | 46.2 kB | ✓ |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 46.4 kB | 46.4 kB | ✓ |
link.js gzip | 71.9 kB | 71.9 kB | ✓ |
routerDirect.js gzip | 69.9 kB | 69.9 kB | ✓ |
withRouter.js gzip | 69.9 kB | 69.9 kB | ✓ |
Overall change | 305 kB | 305 kB | ✓ |
Commit: a3e5c82
timneutkens
reviewed
Jan 22, 2020
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 13.9s | 14s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.1 kB | 4.1 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | ✓ |
link.html gzip | 1.03 kB | 1.03 kB | ✓ |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 14.2s | 14.2s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.1 kB | 4.1 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_error.js gzip | 46.2 kB | 46.2 kB | ✓ |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 46.4 kB | 46.4 kB | ✓ |
link.js gzip | 71.9 kB | 71.9 kB | ✓ |
routerDirect.js gzip | 69.9 kB | 69.9 kB | ✓ |
withRouter.js gzip | 69.9 kB | 69.9 kB | ✓ |
Overall change | 305 kB | 305 kB | ✓ |
Commit: 7ad33e4
jamesmosier
commented
Jan 22, 2020
const resText = await fetchViaHTTP(appPort, '/api/bigint', null, { | ||
method: 'GET', | ||
}).then(res => res.ok && res.text()) | ||
expect(resText).toEqual('3') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BigInt is not JSON serializable from what i've found (tc39/proposal-bigint#162, tc39/proposal-bigint#24), so I'm just going to test that (1n + 2n).toString() = 3
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 13s | 13.2s | |
nodeModulesSize | 51 MB | 51 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.1 kB | 4.1 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | ✓ |
link.html gzip | 1.03 kB | 1.03 kB | ✓ |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 13.6s | 13.9s | |
nodeModulesSize | 51 MB | 51 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.1 kB | 4.1 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_error.js gzip | 46.2 kB | 46.2 kB | ✓ |
hooks.html gzip | 1.06 kB | 1.06 kB | ✓ |
index.js gzip | 46.4 kB | 46.4 kB | ✓ |
link.js gzip | 71.9 kB | 71.9 kB | ✓ |
routerDirect.js gzip | 69.9 kB | 69.9 kB | ✓ |
withRouter.js gzip | 69.9 kB | 69.9 kB | ✓ |
Overall change | 305 kB | 305 kB | ✓ |
Commit: 401ca99
Timer
approved these changes
Jan 27, 2020
Stats from current PRDefault Server ModeGeneral Overall increase
|
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 10.7s | 10.7s | -7ms |
nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.09 kB | 4.09 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | ✓ |
link.html gzip | 1.03 kB | 1.03 kB | ✓ |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.07 kB | 3.07 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
buildDuration | 11.4s | 10.6s | -837ms |
nodeModulesSize | 52.1 MB | 52.1 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..d57b.js gzip | 16.1 kB | 16.1 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 69.8 kB | 69.8 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.09 kB | 4.09 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 15 kB | 15 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 64.5 kB | 64.5 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.js gzip | 1.15 kB | 1.15 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.89 kB | 2.89 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.68 kB | 9.68 kB | ✓ |
Client Pages Modern
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_app.module.js gzip | 576 B | 576 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.46 kB | 2.46 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.22 kB | 7.22 kB | ✓ |
Client Build Manifests
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | jamesmosier/next.js patch/7980 | Change | |
---|---|---|---|
_error.js gzip | 46.2 kB | 46.2 kB | ✓ |
hooks.html gzip | 1.06 kB | 1.06 kB | ✓ |
index.js gzip | 46.4 kB | 46.4 kB | ✓ |
link.js gzip | 71.9 kB | 71.9 kB | ✓ |
routerDirect.js gzip | 69.9 kB | 69.9 kB | ✓ |
withRouter.js gzip | 69.9 kB | 69.9 kB | ✓ |
Overall change | 305 kB | 305 kB | ✓ |
Commit: be220fe
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7980. Added BigInt support for API routes only.