Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade koa router in example #10469

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Upgrade koa router in example #10469

merged 2 commits into from
Feb 8, 2020

Conversation

Nainterceptor
Copy link
Contributor

A very small change : koa-router is now deprecated, and has been integrated into koa project itself under the package name @koa/router.

As a reference, please see the call for maintainers part of README.md

@ijjk
Copy link
Member

ijjk commented Feb 8, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
buildDuration 11.8s 11.9s ⚠️ +147ms
nodeModulesSize 52.6 MB 52.6 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e781.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
index.html gzip 1.03 kB 1.03 kB ✓
link.html gzip 1.04 kB 1.04 kB ✓
withRouter.html gzip 1.03 kB 1.03 kB ✓
Overall change 3.11 kB 3.11 kB ✓
Serverless Mode
General
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
buildDuration 12.5s 12.5s ⚠️ +10ms
nodeModulesSize 52.6 MB 52.6 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
main-HASH.js gzip 5.13 kB 5.13 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e781.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
main-HASH.module.js gzip 4.13 kB 4.13 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Nainterceptor/next.js upgrade-koa-example Change
_error.js gzip 46.6 kB 46.6 kB ✓
404.html gzip 1.45 kB 1.45 kB ✓
hooks.html gzip 1.08 kB 1.08 kB ✓
index.js gzip 46.7 kB 46.7 kB ✓
link.js gzip 72.6 kB 72.6 kB ✓
routerDirect.js gzip 70.8 kB 70.8 kB ✓
withRouter.js gzip 70.6 kB 70.6 kB ✓
Overall change 310 kB 310 kB ✓

Commit: b94595a

Timer
Timer approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Timer Timer merged commit e382997 into vercel:canary Feb 8, 2020
@Timer Timer added this to the 9.2.2 milestone Feb 8, 2020
@Timer Timer added the examples Issue/PR related to examples label Feb 8, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020
@Nainterceptor @chibicode
Upgrade koa router in example (vercel#10469)
a498288 
* Upgrade koa router

* Change koa import
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Nainterceptor @ijjk @Timer