Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nested Index Dynamic Routes in Development #10595

Merged
merged 5 commits into from
Feb 19, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Feb 19, 2020

next-dev-server assumed all the files enumerated in the pages/ directory were pages.

Instead of stripping the extension, we first check for its presence to be a valid page, then strip it!

I've added a test case for when this would trigger and cause an error.


Closes #10594

@Timer Timer added this to the 9.3.0 milestone Feb 19, 2020
@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 9.3s 9.7s ⚠️ +414ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
index.html gzip 925 B 925 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 10.1s 10.3s ⚠️ +174ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_error.js gzip 289 kB 289 kB ⚠️ +186 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 964 B 964 B
index.js gzip 290 kB 290 kB ⚠️ +185 B
link.js gzip 299 kB 299 kB -132 B
routerDirect.js gzip 296 kB 297 kB ⚠️ +917 B
withRouter.js gzip 297 kB 298 kB ⚠️ +955 B
Overall change 1.47 MB 1.47 MB ⚠️ +2.11 kB

Commit: f2ae5bd

@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 10.6s 11.4s ⚠️ +730ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
index.html gzip 925 B 925 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 11.7s 11.5s -237ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_error.js gzip 289 kB 290 kB ⚠️ +876 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 964 B 964 B
index.js gzip 289 kB 290 kB ⚠️ +1.04 kB
link.js gzip 297 kB 297 kB ⚠️ +185 B
routerDirect.js gzip 296 kB 296 kB -2 B
withRouter.js gzip 298 kB 296 kB -1.14 kB
Overall change 1.47 MB 1.47 MB ⚠️ +952 B

Commit: f2ae5bd

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the routes manifest for the dynamic-routing suite needs to be updated

@Timer Timer requested a review from ijjk February 19, 2020 15:51
@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 9.5s 9.5s ⚠️ +23ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
index.html gzip 925 B 925 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 10.3s 10s -377ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_error.js gzip 289 kB 289 kB -76 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 964 B 964 B
index.js gzip 290 kB 289 kB -508 B
link.js gzip 297 kB 299 kB ⚠️ +1.25 kB
routerDirect.js gzip 297 kB 297 kB -18 B
withRouter.js gzip 296 kB 298 kB ⚠️ +1.49 kB
Overall change 1.47 MB 1.47 MB ⚠️ +2.14 kB

Commit: 98c5128

@ijjk
Copy link
Member

ijjk commented Feb 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 11.4s 11.6s ⚠️ +231ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
index.html gzip 925 B 925 B
link.html gzip 933 B 933 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
buildDuration 12.7s 12.2s -433ms
nodeModulesSize 53.8 MB 53.8 MB ⚠️ +143 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.js gzip 5.05 kB 5.05 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..abdd.js gzip 12.2 kB 12.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57.2 kB 57.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
main-HASH.module.js gzip 4.14 kB 4.14 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 9.2 kB 9.2 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
polyfills-HASH.js gzip 20.3 kB 20.3 kB
Overall change 20.3 kB 20.3 kB
Client Pages
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.js gzip 1.06 kB 1.06 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.9 kB 1.9 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_app.module.js gzip 577 B 577 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js fix/dynamic-routes-dev Change
_error.js gzip 289 kB 290 kB ⚠️ +801 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 964 B 964 B
index.js gzip 289 kB 289 kB ⚠️ +275 B
link.js gzip 299 kB 297 kB -1.42 kB
routerDirect.js gzip 297 kB 296 kB -327 B
withRouter.js gzip 296 kB 297 kB ⚠️ +723 B
Overall change 1.47 MB 1.47 MB ⚠️ +56 B

Commit: 4bc120a

@Timer Timer merged commit a30e94f into vercel:canary Feb 19, 2020
@Timer Timer deleted the fix/dynamic-routes-dev branch February 19, 2020 16:36
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Catch-all must be the last part of the URL." error triggered on CSS files
2 participants