upgrade next-transpile-modules to latest everywhere #10607

vvo · 2020-02-20T09:25:34Z

Following #10492 and comment from @timneutkens I went ahead and updated all
examples relying on next-transpile-modules.

@timneutkens

Following vercel#10492 and comment from @timneutkens I went ahead and updated all examples relying on next-transpile-modules.

ijjk · 2020-02-20T09:31:06Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
buildDuration	9.1s	9.2s	⚠️ +92ms
nodeModulesSize	54.5 MB	54.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9ee3.js gzip	12.2 kB	12.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.2 kB	9.2 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
polyfills-HASH.js gzip	20.3 kB	20.3 kB	✓
Overall change	20.3 kB	20.3 kB	✓

Client Pages

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
index.html gzip	925 B	925 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Increase detected ⚠️)

General

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
buildDuration	10s	9.9s	-76ms
nodeModulesSize	54.5 MB	54.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9ee3.js gzip	12.2 kB	12.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.2 kB	9.2 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
polyfills-HASH.js gzip	20.3 kB	20.3 kB	✓
Overall change	20.3 kB	20.3 kB	✓

Client Pages

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_error.js gzip	290 kB	289 kB	-489 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	964 B	964 B	✓
index.js gzip	290 kB	289 kB	-686 B
link.js gzip	297 kB	298 kB	⚠️ +786 B
routerDirect.js gzip	297 kB	296 kB	-707 B
withRouter.js gzip	296 kB	298 kB	⚠️ +1.51 kB
Overall change	1.47 MB	1.47 MB	⚠️ +416 B

Commit: 5c2a97f

timneutkens · 2020-02-20T09:40:14Z

yarn run v1.21.1
$ run-p lint-typescript prettier-check lint-eslint
$ eslint . --ext js,jsx,ts,tsx --max-warnings=0
$ lerna run typescript
$ prettier --check "**/*.{js,jsx,json,ts,tsx,md,mdx,css,html,yml,yaml,scss}"
Checking formatting...
lerna notice cli v3.14.1
lerna info Executing command in 1 package: "yarn run typescript"
errors/invalid-getstaticpaths-value.md
lerna info run Ran npm script 'typescript' in 'next' in 27.4s:
lerna success run Ran npm script 'typescript' in 1 package in 27.4s:
lerna success - next
$ tsc --noEmit --declaration
Code style issues found in the above file(s). Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "prettier-check" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
##[error]Process completed with exit code 1.

Looks like the pre-commit hook didn't run 🤔

vvo · 2020-02-20T11:25:26Z

@timneutkens I dunno what's wrong actually.

I think the current canary branch is broken itself since db445db and its build: https://github.com/zeit/next.js/runs/457307215

Let me know if I need to change something still!

…erywhere

vvo · 2020-02-20T11:33:35Z

Just updated the PR with latest canary changes, I guess this should pass now

ijjk · 2020-02-20T11:38:52Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
buildDuration	9s	10.8s	⚠️ +1.8s
nodeModulesSize	54.5 MB	54.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9ee3.js gzip	12.2 kB	12.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.2 kB	9.2 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
polyfills-HASH.js gzip	20.3 kB	20.3 kB	✓
Overall change	20.3 kB	20.3 kB	✓

Client Pages

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
index.html gzip	925 B	925 B	✓
link.html gzip	934 B	934 B	✓
withRouter.html gzip	923 B	923 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode (Increase detected ⚠️)

General

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
buildDuration	9.6s	9.3s	-286ms
nodeModulesSize	54.5 MB	54.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.js gzip	5.05 kB	5.05 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9ee3.js gzip	12.2 kB	12.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
main-HASH.module.js gzip	4.14 kB	4.14 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	9.2 kB	9.2 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	53.2 kB	53.2 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
polyfills-HASH.js gzip	20.3 kB	20.3 kB	✓
Overall change	20.3 kB	20.3 kB	✓

Client Pages

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.js gzip	1.06 kB	1.06 kB	✓
_error.js gzip	2.98 kB	2.98 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.9 kB	1.9 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_app.module.js gzip	577 B	577 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	vvo/next.js upgrade-next-transpile-modules-to-3.0.2-everywhere	Change
_error.js gzip	290 kB	289 kB	-742 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	964 B	964 B	✓
index.js gzip	290 kB	290 kB	⚠️ +180 B
link.js gzip	298 kB	297 kB	-611 B
routerDirect.js gzip	296 kB	298 kB	⚠️ +1.73 kB
withRouter.js gzip	296 kB	298 kB	⚠️ +1.38 kB
Overall change	1.47 MB	1.47 MB	⚠️ +1.94 kB

Commit: 7007fdd

timneutkens · 2020-02-20T11:44:27Z

Thanks @vvo! This was my fault as explained on the commit message 🙈

upgrade next-transpile-modules to latest everywhere

5c2a97f

Following vercel#10492 and comment from @timneutkens I went ahead and updated all examples relying on next-transpile-modules.

vvo requested review from lfades and Timer as code owners February 20, 2020 09:25

vvo mentioned this pull request Feb 20, 2020

Upgrade next-transpile-modules in workspace examples #10492

Merged

Merge branch 'canary' into upgrade-next-transpile-modules-to-3.0.2-ev…

7007fdd

…erywhere

timneutkens merged commit f0c8230 into vercel:canary Feb 20, 2020

vvo deleted the upgrade-next-transpile-modules-to-3.0.2-everywhere branch March 3, 2020 21:29

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade next from 9.1.1 to 9.3.1 cds-snc/a11y-reporting#6

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade next-transpile-modules to latest everywhere #10607

upgrade next-transpile-modules to latest everywhere #10607

vvo commented Feb 20, 2020

ijjk commented Feb 20, 2020

timneutkens commented Feb 20, 2020

vvo commented Feb 20, 2020 •

edited

Loading

vvo commented Feb 20, 2020

ijjk commented Feb 20, 2020

timneutkens commented Feb 20, 2020

upgrade next-transpile-modules to latest everywhere #10607

upgrade next-transpile-modules to latest everywhere #10607

Conversation

vvo commented Feb 20, 2020

ijjk commented Feb 20, 2020

Stats from current PR

timneutkens commented Feb 20, 2020

vvo commented Feb 20, 2020 • edited Loading

vvo commented Feb 20, 2020

ijjk commented Feb 20, 2020

Stats from current PR

timneutkens commented Feb 20, 2020

vvo commented Feb 20, 2020 •

edited

Loading