Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dangerousAsPath from RenderOpts #10773

Merged
merged 1 commit into from
Mar 1, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Mar 1, 2020

This removes dangerousAsPath from RenderOpts, as it's not necessary to be provided by the rendering request pipeline.

This option is one of the reasons next-server uses the any type instead of a concrete type.

This property is already a part of DocumentProps, which is already unconditionally injected at the callsite of renderDocument:
image

@Timer Timer added this to the 9.3.0 milestone Mar 1, 2020
@ijjk
Copy link
Member

ijjk commented Mar 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/invalid-typing Change
buildDuration 10.6s 10.9s ⚠️ +274ms
nodeModulesSize 56.3 MB 56.3 MB -55 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/invalid-typing Change
main-HASH.js gzip 5.41 kB 5.41 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55 kB 55 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/invalid-typing Change
main-HASH.module.js gzip 4.44 kB 4.44 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51 kB 51 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/invalid-typing Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove/invalid-typing Change
index.html gzip 924 B 924 B
link.html gzip 934 B 934 B
withRouter.html gzip 923 B 923 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/invalid-typing Change
buildDuration 12.3s 12.1s -154ms
nodeModulesSize 56.3 MB 56.3 MB -55 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/invalid-typing Change
main-HASH.js gzip 5.41 kB 5.41 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55 kB 55 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/invalid-typing Change
main-HASH.module.js gzip 4.44 kB 4.44 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51 kB 51 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/invalid-typing Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB
Overall change 18.9 kB 18.9 kB
Client Pages
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_app.js gzip 1.07 kB 1.07 kB
_error.js gzip 2.98 kB 2.98 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_app.module.js gzip 589 B 589 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.27 kB 5.27 kB
Client Build Manifests
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/invalid-typing Change
_error.js gzip 292 kB 292 kB ⚠️ +446 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 963 B 963 B
index.js gzip 292 kB 292 kB ⚠️ +97 B
link.js gzip 299 kB 300 kB ⚠️ +558 B
routerDirect.js gzip 298 kB 298 kB -123 B
withRouter.js gzip 298 kB 298 kB -262 B
Overall change 1.48 MB 1.48 MB ⚠️ +716 B

Commit: 548f909

@Timer Timer merged commit 302b55b into vercel:canary Mar 1, 2020
@Timer Timer deleted the remove/invalid-typing branch March 1, 2020 17:24
@TommySorensen
Copy link

@Timer
I am using the dangerousAsPath in a custom document to get the url so i know what language is in the url. Like this <Html lang={lang here}>. If you remove the dangerousAsPath here, then how will i get the path of the current page?

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants