Update blog-starter example #11071
Merged
Update blog-starter example #11071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| buildDuration | 9.5s | 9.5s | -88ms |
| nodeModulesSize | 56.6 MB | 56.6 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| main-HASH.js gzip | 5.77 kB | 5.77 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..8eb0.js gzip | 9.78 kB | 9.78 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 55.4 kB | 55.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.2 kB | 26.2 kB | ✓ |
| Overall change | 26.2 kB | 26.2 kB | ✓ |
Client Pages
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| _app.js gzip | 1.09 kB | 1.09 kB | ✓ |
| _error.js gzip | 2.97 kB | 2.97 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 1.89 kB | 1.89 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.39 kB | 7.39 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | timneutkens/next.js add/update-blog-starter | Change | |
|---|---|---|---|
| _error.js gzip | 293 kB | 294 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 957 B | 957 B | ✓ |
| index.js gzip | 294 kB | 294 kB | -10 B |
| link.js gzip | 301 kB | 301 kB | |
| routerDirect.js gzip | 300 kB | 300 kB | |
| withRouter.js gzip | 300 kB | 299 kB | -486 B |
| Overall change | 1.49 MB | 1.49 MB |
|
is it possible to avoid https://og-image.now.sh ? anything like https://www.gatsbyjs.org/packages/gatsby-remark-images/ that can process offline ? |
og-image.now.sh is just a og-image generator we use at ZEIT, it has nothing to do with image processing in particular. You already have an open feature request and an open GitHub discussions thread so doesn't seem relevant to discuss that here. |
chibicode
approved these changes
Mar 17, 2020
|
Looks good, but which account is https://next-blog-starter.now.sh/ deployed to? I tweaked CSS and made it display excerpt, so it needs to be re-deployed. |
lfades
approved these changes
Mar 17, 2020
chibicode
changed the title
timneutkens
commented
Mar 18, 2020
|
@timneutkens thank you for this update! would it be possible for you to illustrate pagination in here ? it would be really helpful to see how that works with the new apis. |
This was referenced Apr 13, 2020
This was referenced Apr 22, 2020
|
@timneutkens Will there be another example that uses MDX instead of plain Markdown? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on one of the CMS examples, but with Markdown from the filesystem as datasource 💯
Left to be done:
When creating more examples for other Headless CMSs, we need to modify the following:
README.md(the most time consuming part)package.json- Updatenameand removereact-datocms.env.example- Use different env variable namesnext.config.js- Use different env variable nameslib/api.jsnow.jsonpages/index.js- UpdategetStaticPropspages/posts/[slug].js- UpdategetStaticPropsandgetStaticPathspages/api/preview.js- Update the secret environment variable (NEXT_EXAMPLE_CMS_DATOCMS_PREVIEW_SECRET)lib/constants.js- ogp image is created on https://og-image.now.sh (config)lib/markdownToHtml.js- DatoCMS sends down markdown so we had to convert it to HTML, but might not be necessary for other CMSscomponents/cover-image.js- Usesreact-datocmsto render progressive images.Also, add to the "More Examples" section on:
docs/basic-features/pages.mddocs/basic-features/data-fetching.mddocs/advanced-features/preview-mode.md