Fix assignment of props in WithApollo.getInitialProps

[bgoerdt]

The props are being assigned incorrectly based on the inAppContext, they should be wrapped in pageProps when inAppContext is true, not the other way around. This bug will cause a new apollo client to be created during getDataFromTree instead of using the one that has already been created on the server.

[lfades]

@bgoerdt Thank you!

[antoniojps]

Hey, this is unrelated to this PR. However I couldn't find a better place to ask.

In the following snippet...

 // We consider installing `withApollo({ ssr: true })` on global App level
  // as antipattern since it disables project wide Automatic Static Optimization.
  if (process.env.NODE_ENV === 'development') {
    if (inAppContext) {
      console.warn(
        'Warning: You have opted-out of Automatic Static Optimization due to `withApollo` in `pages/_app`.\n' +
          'Read more: https://err.sh/next.js/opt-out-auto-static-optimization\n'
      )
    }
  }

...the comment says that it is an antipattern to use withApollo({ ssr: true }) on global App level. So is it an antipattern to use with SSR set to false on the App level?

If not, shouldn't this warning be ignored if SSR is false?

[lfades]

@antoniojps It should be ignored, yes. If that's not the case you're welcome to open a PR to fix it.

[zanettin]

hi @bgoerdt 👋
since this PR both variations (hoc on _app and hoc on pages) do no longer work on my end. data are just fetched on the client and not on ssr. you can also try the example locally and check NEXT_DATA and search for the gql request on the network tab. note that the api has reached it's limit so i've tested the example code agains swapi.graph.cool and rewrote the post component to fetch films out of it.

is it possible that you re-check it and maybe undo your changes? for me it's not an issue since i have a custom solution anyway but maybe for others it could be misleading. thanks for your contribution 👍

[bgoerdt]

@zanettin yep I'll revert it. I'm not sure why it's working the opposite way in my project, but the example project is broken with my change. Sorry about that.

[zanettin]

@bgoerdt top. thx a lot 👍 nave a nice weekend