Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix assignment of props in WithApollo.getInitialProps" #11384

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

bgoerdt
Copy link
Contributor

@bgoerdt bgoerdt commented Mar 26, 2020

Reverts #11236

@zanettin

This PR broke the example project. Sorry folks 🙏. The change is required for it to work in my project for some reason but it does not work in the example project. Perhaps it is due to a version difference or some other config mismatch.

@bgoerdt bgoerdt requested review from lfades and Timer as code owners March 26, 2020 23:20
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgoerdt No worries, thank you for fixing it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants