Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to public folder in with-loading example #9016

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Change to public folder in with-loading example #9016

merged 1 commit into from
Oct 9, 2019

Conversation

ismamz
Copy link
Contributor

@ismamz ismamz commented Oct 9, 2019

No description provided.

@ismamz ismamz requested review from lfades and Timer as code owners October 9, 2019 22:24
@lfades lfades merged commit 6ce6b96 into vercel:canary Oct 9, 2019
@Janpot
Copy link
Contributor

Janpot commented Oct 9, 2019

@ismamz @lfades Looks like there's a few more examples where static folder is still being used:

$ find examples/*/static/*
examples/blog-starter/static/_jolvera.png
examples/blog-starter/static/favicon.ico
examples/blog-starter/static/next.svg
examples/blog-starter/static/site-feature.png
examples/with-algolia-react-instantsearch/static/favicon.ico
examples/with-algolia-react-instantsearch/static/instantsearch.css
examples/with-asset-imports/static/logo.png
examples/with-carbon-components/static/export.scss
examples/with-carbon-components/static/myCustomTheme.scss
examples/with-firebase-cloud-messaging/static/firebase-messaging-sw.js
examples/with-loading/static/nprogress.css
examples/with-noscript/static/img
examples/with-noscript/static/img/nextjs.png
examples/with-noscript/static/img/angular.jpg
examples/with-noscript/static/img/reactjs.png
examples/with-noscript/static/img/vuejs.png
examples/with-react-md/static/react-md.light_blue-yellow.min.css
examples/with-react-toolbox/static/theme.css
examples/with-react-toolbox/static/theme.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants