Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the npm node #20

Open
keptan opened this issue Sep 21, 2018 · 8 comments
Open

Updating the npm node #20

keptan opened this issue Sep 21, 2018 · 8 comments

Comments

@keptan
Copy link
Contributor

keptan commented Sep 21, 2018

https://www.npmjs.com/package/node-rpi-rgb-led-matrix
is still tracking the 3 year old version,
I plan on releasing some node modules pulling the new 64x64 enabled library as an npm dependency in the near future; and will be actively maintaining my fork as well.

I could either put my fork up as a new npm package, or could become a maintainer of this version on github/npm if you're up for it.

@wbobeirne
Copy link

Just wanted to chime in support and say I'd love to use this module from npm, so it would be great to have it be up to date!

It looks like the owner of this repo hasn't had a lot of activity recently, so a maintained fork may be best.

@zeitungen
Copy link
Owner

Damn! I don't see this issue ... My bad ..
I try to look in this few days how to transfer (or share) this skills (maintain the git repo and publish new module version into npm).

@zeitungen
Copy link
Owner

If someone is always ready to publish in npm and/or maintain the repo I can give him access. Just tell me (and eventually insist if I did not respond)

@keptan
Copy link
Contributor Author

keptan commented Jan 15, 2019

Maintaining our own npm package at this point: https://www.npmjs.com/package/easybotics-rpi-rgb-led-matrix
https://github.com/easybotics/node-rpi-rgb-led-matrix
It has some changes and additions, like brightness handling and font caching and drawing.

I'm totally willing to polish it up a bit, make a pull request and maintain your npm repo in the near future if you want.

@zeitungen
Copy link
Owner

zeitungen commented Jan 16, 2019

Perhaps the best move are:

  • for my github repo: put message in bold red saying "this repo not maintainig go to see [your fork repo]" and in a near future I can delete this repo
  • for the npm module: give you ownership to the moduule or delete the module if it's possible

What do you think about it ?

@keptan
Copy link
Contributor Author

keptan commented Jan 17, 2019

Probably best not to delete anything; for the people who might rely on older versions of this repo. But a 'not maintained' message probably works.

I can be added as a owner of the npm, and bring it inline with a working version of your repo.
My npm account is here: https://www.npmjs.com/~keptan

The way I see it, the only issue with the npm package is that its 3 years old, not really essential that it receives whatever new features that are in my fork. So both can coexist once its updated.

@zeitungen
Copy link
Owner

I had a link to your repo in readme.
And I have add you as maintainer via the npm ui to my npm module.

@keptan
Copy link
Contributor Author

keptan commented Jan 23, 2019

thanks, I updated the npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants