-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "frontend JS/HTML" great again! #4
Comments
@Peck07 : I got that: Not totally as your (position order) What work (need a little more test/check)
What I will check soon:
todo: adapt the CSS/html taking gates number into consideration! But we have an almost working version now :-D (but far from bug-free) |
It's a feature :) but yes, I've also encountered it. the algo is simple right now, if a rank comes in, and it's not "visible", just creates the line for it. If the ranks don't come in order, it won't be created in order :) (typically happens when you start/refresh the page while the Race is running) Fix shouldn't be complicated. And apart from the displayed order, everything is updated in the correct line. Yes, of course a lot of things need some fine tuning, or have some little defect :) but that's only the beginning of a beautiful friendship :) Edit: already corrected the position order: Peck07@a8fa532 |
How to fix easily the position/rank change between too player? keep old value with the new position/rank -> put new value at new position/rank -> put back old value to old position/rank ... ie: I'm on the player name server<->client
|
If the backend sends the changed positions... it will be updated automatically on the frontend (hopefully). Player name: I've started to read the config on the frontend side :) |
Made the player name/color handling: #7 |
In the serial: F and B And both name and color values aren't read ... |
I have seen it, sends Player 1, 2, 3, 4 with colors, but the id-s are 0 for every record |
1h for looking why id-s are at 0 whatever I put/try... I was blind ... == instead = ... 👎 So yes!! color working :-D |
strange behaviour now, changed the player 2 number to 0112, and got 74, and half working color now... |
Lol, 0112 was interpreted as an oct! :) which is 74 in dec. |
Yes I have seen it... but as the receiver send 0x (hex) if i remember well, to test color i have put simple dec, and now it's cast in oct. it's a feature not a bug. So removing the leading 0 will be done for the testing, but need a sanity check, even more when there will be server <-> client id transmission. |
Right now the id-s are treated as integers, so it shouldn't matter if it's received in hex, but let's keep an eye on them :) |
man: snprintf, remember:
|
Todo: change breaking change with the new JSON API, and merge work done from @Peck07 (waiting pull requests :-D)
The text was updated successfully, but these errors were encountered: