Skip to content

Commit 8fd8135

Browse files
committed
chore: adds storybook and readme updates
1 parent 5e39f90 commit 8fd8135

File tree

3 files changed

+29
-42
lines changed

3 files changed

+29
-42
lines changed

docs/migration.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ consider additional positioning prop support on a case-by-case basis.
4444
#### @zendeskgarden/react-chrome
4545

4646
- Removed `PRODUCT` type export. Use `IHeaderItemProps['product']` instead.
47+
- Some subcomponent exports have been deprecated and will be removed in a future major version.
48+
Update to subcomponent properties.
4749

4850
#### @zendeskgarden/react-colorpickers
4951

packages/chrome/README.md

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,41 +15,37 @@ npm install react react-dom styled-components @zendeskgarden/react-theming
1515

1616
```jsx
1717
import { ThemeProvider } from '@zendeskgarden/react-theming';
18-
import { Chrome, Nav, NavItem, ... } from '@zendeskgarden/react-chrome';
18+
import { Chrome, Nav, SubNav, Body, Header, Content, Main } from '@zendeskgarden/react-chrome';
1919
import ConnectIcon from '@zendeskgarden/icons/src/26/relationshape-connect.svg';
2020

2121
<ThemeProvider>
2222
<Chrome>
2323
<Nav isExpanded>
24-
<NavItem hasLogo product="connect" title="Zendesk Connect">
25-
<NavItemIcon>
24+
<Nav.Item hasLogo product="connect" title="Zendesk Connect">
25+
<Nav.ItemIcon>
2626
<ConnectIcon />
27-
</NavItemIcon>
27+
</Nav.ItemIcon>
2828
<NavItemText>Zendesk Connect</NavItemText>
29-
</NavItem>
30-
<NavItem isCurrent>
31-
<NavItemIcon>
29+
</Nav.Item>
30+
<Nav.Item isCurrent>
31+
<Nav.ItemIcon>
3232
<HomeIcon />
33-
</NavItemIcon>
33+
</Nav.ItemIcon>
3434
<NavItemText>Home</NavItemText>
35-
</NavItem>
35+
</Nav.Item>
3636
</Nav>
3737
<SubNav>
38-
<SubNavItem isCurrent>
39-
<SubNavItemText>Subnav 1</SubNavItemText>
40-
</SubNavItem>
38+
<SubNav.Item isCurrent>
39+
<SubNav.ItemText>Subnav 1</SubNav.ItemText>
40+
</SubNav.Item>
4141
...
4242
</SubNav>
4343
<Body>
44-
<Header>
45-
...
46-
</Header>
44+
<Header>...</Header>
4745
<Content>
48-
<Main>
49-
Lorem ipsum...
50-
</Main>
46+
<Main>Lorem ipsum...</Main>
5147
</Content>
5248
</Body>
5349
</Chrome>
54-
</ThemeProvider>
50+
</ThemeProvider>;
5551
```

packages/chrome/demo/chrome.stories.mdx

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,17 @@
11
import { Meta, ArgsTable, Canvas, Story, Markdown } from '@storybook/addon-docs';
22
import { useArgs } from '@storybook/client-api';
33
import {
4-
Chrome,
5-
CollapsibleSubNavItem,
64
Body,
5+
Chrome,
76
Content,
87
Footer,
9-
FooterItem,
108
Header,
11-
HeaderItem,
12-
HeaderItemIcon,
13-
HeaderItemText,
14-
HeaderItemWrapper,
159
Main,
1610
Nav,
17-
NavItem,
18-
NavItemIcon,
19-
NavItemText,
2011
Sheet,
2112
Sidebar,
2213
SkipNav,
2314
SubNav,
24-
SubNavItem,
25-
SubNavItemText,
2615
PRODUCTS
2716
} from '@zendeskgarden/react-chrome';
2817
import { ChromeStory } from './stories/ChromeStory';
@@ -44,27 +33,27 @@ import README from '../README.md';
4433
title="Packages/Chrome/Chrome"
4534
component={Chrome}
4635
subcomponents={{
47-
CollapsibleSubNavItem,
4836
Body,
4937
Content,
5038
Footer,
51-
FooterItem,
39+
'Footer.Item': Footer.Item,
5240
Header,
53-
HeaderItem,
54-
HeaderItemIcon,
55-
HeaderItemText,
56-
HeaderItemWrapper,
41+
'Item.HeaderItem': Header.Item,
42+
'Item.HeaderItemIcon': Header.ItemIcon,
43+
'Item.HeaderItemText': Header.ItemText,
44+
'Item.HeaderItemWrapper': Header.ItemWrapper,
5745
Main,
5846
Nav,
59-
NavItem,
60-
NavItemIcon,
61-
NavItemText,
47+
'Nav.Item': Nav.Item,
48+
'Nav.ItemIcon': Nav.ItemIcon,
49+
'Nav.ItemText': Nav.ItemText,
6250
Sheet,
6351
Sidebar,
6452
SkipNav,
6553
SubNav,
66-
SubNavItem,
67-
SubNavItemText
54+
'SubNav.CollapsibleItem': SubNav.CollapsibleItem,
55+
'Sub.NavItem': Sub.NavItem,
56+
'Sub.NavItemText': Sub.NavItemText
6857
}}
6958
/>
7059

0 commit comments

Comments
 (0)