fix: remove props as optional

Author: Mike Tobia

packages/accordion/.size-snapshot.json

@@ -19,21 +19,21 @@
     }
   },
   "index.cjs.js": {
-    "bundled": 4504,
-    "minified": 2293,
-    "gzipped": 975
+    "bundled": 4402,
+    "minified": 2227,
+    "gzipped": 961
   },
   "index.esm.js": {
-    "bundled": 4363,
-    "minified": 2153,
-    "gzipped": 969,
+    "bundled": 4261,
+    "minified": 2087,
+    "gzipped": 952,
     "treeshaked": {
       "rollup": {
         "code": 162,
         "import_statements": 83
       },
       "webpack": {
-        "code": 2234
+        "code": 2168
       }
     }
   }

packages/accordion/demo/stories/data.ts

@@ -5,6 +5,4 @@
  * found at http://www.apache.org/licenses/LICENSE-2.0.
  */
 
-export const SECTIONS = Array(5)
-  .fill(undefined)
-  .map((_, i) => i);
+export const SECTIONS = ['section-1', 'section-2', 'section-3', 'section-4', 'section-5'];

packages/accordion/src/AccordionContainer.spec.tsx

@@ -43,31 +43,13 @@ describe('AccordionContainer', () => {
           {sections.map(section => {
             return (
               <div key={section}>
-                <div
-                  {...getHeaderProps({
-                    'aria-level': 1,
-                    // @ts-expect-error data-test-id for testing
-                    'data-test-id': 'header'
-                  })}
-                >
-                  <div
-                    {...getTriggerProps({
-                      value: section,
-                      // @ts-expect-error data-test-id for testing
-                      'data-test-id': 'trigger'
-                    })}
-                  >
+                <div data-test-id="header" {...getHeaderProps({ 'aria-level': 1 })}>
+                  <div data-test-id="trigger" {...getTriggerProps({ value: section })}>
                     Trigger
                   </div>
                 </div>
 
-                <div
-                  {...getPanelProps({
-                    value: section,
-                    // @ts-expect-error data-test-id for testing
-                    'data-test-id': 'panel'
-                  })}
-                >
+                <div data-test-id="panel" {...getPanelProps({ value: section })}>
                   Panel
                 </div>
               </div>

packages/accordion/src/types.ts

@@ -28,19 +28,19 @@ export interface IUseAccordionReturnValue<Value> {
   expandedSections: Value[];
   disabledSections: Value[];
   getHeaderProps: <T extends Element>(
-    props?: Omit<HTMLProps<T>, 'role' | 'aria-level'> & {
+    props: Omit<HTMLProps<T>, 'role' | 'aria-level'> & {
       role?: 'heading' | null;
       'aria-level': NonNullable<HTMLProps<T>['aria-level']>;
     }
   ) => HTMLProps<T>;
   getTriggerProps: <T extends Element>(
-    props?: Omit<HTMLProps<T>, 'role'> & {
+    props: Omit<HTMLProps<T>, 'role'> & {
       role?: 'button' | null;
       value: Value;
     }
   ) => HTMLProps<T>;
   getPanelProps: <T extends Element>(
-    props?: Omit<HTMLProps<T>, 'role'> & {
+    props: Omit<HTMLProps<T>, 'role'> & {
       role?: 'region' | null;
       value: Value;
     }

packages/accordion/src/useAccordion.ts

@@ -70,7 +70,7 @@ export function useAccordion<Value>({
   );
 
   const getHeaderProps = useCallback(
-    ({ role = 'heading', 'aria-level': ariaLevel, ...props } = {}) => ({
+    ({ role = 'heading', 'aria-level': ariaLevel, ...props }) => ({
       role,
       'aria-level': ariaLevel,
       'data-garden-container-id': 'containers.accordion',
@@ -81,7 +81,7 @@ export function useAccordion<Value>({
   );
 
   const getTriggerProps = useCallback(
-    ({ value, role = 'button', tabIndex = 0, ...props } = {}) => ({
+    ({ value, role = 'button', tabIndex = 0, ...props }) => ({
       id: `${TRIGGER_ID}:${value}`,
       role,
       tabIndex,
@@ -101,7 +101,7 @@ export function useAccordion<Value>({
   );
 
   const getPanelProps = useCallback(
-    ({ value, role = 'region', ...props } = {}) => ({
+    ({ value, role = 'region', ...props }) => ({
       id: `${PANEL_ID}:${value}`,
       role,
       'aria-hidden': !internalExpandedState.includes(value),