Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit 1d20fd1

Browse files
committed
Merge branch 'remove-tests-catch-fail' of https://github.com/Maks3w/zf2 into hotfix/tests-exceptions

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

test/Client/StaticTest.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,9 @@ public function testOpenTempStreamWithValidFileDoesntThrowsException()
484484
'outputstream' => realpath(__DIR__ . '/_files/zend_http_client_stream.file'),
485485
);
486486
$client = new HTTPClient($url, $config);
487-
try {
488-
$result = $client->send();
489-
} catch (Http\Exception\ExceptionInterface $e) {
490-
$this->fail('Unexpected exception was thrown: ' . $e->getMessage() . "\n" . $e->getTraceAsString());
491-
}
487+
488+
$result = $client->send();
489+
492490
// we can safely return until we can verify link is still active
493491
// @todo verify link is still active
494492
return;

test/ClientTest.php

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,10 @@ public function testClientRetrievesUppercaseHttpMethodFromRequestObject()
1717

1818
public function testIfZeroValueCookiesCanBeSet()
1919
{
20-
try {
21-
$client = new Client();
22-
$client->addCookie("test", 0);
23-
$client->addCookie("test2", "0");
24-
$client->addCookie("test3", false);
25-
} catch (Exception\InvalidArgumentException $e) {
26-
$this->fail('Zero Values should be valid');
27-
}
28-
$this->assertTrue(true);
20+
$client = new Client();
21+
$client->addCookie("test", 0);
22+
$client->addCookie("test2", "0");
23+
$client->addCookie("test3", false);
2924
}
3025

3126
/**

0 commit comments

Comments
 (0)