Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit 9594ad4

Browse files
committed
Merge branch 'master' of git://github.com/zendframework/zf2 into cache_missingItems
Conflicts: library/Zend/Cache/Storage/Adapter/AbstractAdapter.php tests/Zend/Cache/Storage/Adapter/CommonAdapterTest.php
17 parents f02a226 + 00c4ac3 + 76452c1 + 8181c8f + 5508474 + 49ed2f6 + d562686 + 67b42b2 + bdb1dae + 9809630 + 53bdac2 + c2f9414 + 9136e70 + 1d802ce + 3f52720 + 7304e37 + 752a5af commit 9594ad4

File tree

10 files changed

+331
-107
lines changed

10 files changed

+331
-107
lines changed

src/Client.php

Lines changed: 22 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,13 @@
2525
Zend\Uri\Http,
2626
Zend\Http\Header\Cookie,
2727
Zend\Http\Header\SetCookie,
28+
Zend\Http\Request as HttpRequest,
29+
Zend\Http\Response as HttpResponse,
30+
Zend\Http\Response\Stream as HttpResponseStream,
2831
Zend\Stdlib\Parameters,
29-
Zend\Stdlib\ParametersDescription,
30-
Zend\Stdlib\Dispatchable,
31-
Zend\Stdlib\RequestDescription,
32-
Zend\Stdlib\ResponseDescription;
32+
Zend\Stdlib\DispatchableInterface as Dispatchable,
33+
Zend\Stdlib\RequestInterface as Request,
34+
Zend\Stdlib\ResponseInterface as Response;
3335

3436
/**
3537
* Http client
@@ -124,7 +126,7 @@ class Client implements Dispatchable
124126
'useragent' => 'Zend\Http\Client',
125127
'timeout' => 10,
126128
'adapter' => 'Zend\Http\Client\Adapter\Socket',
127-
'httpversion' => Request::VERSION_11,
129+
'httpversion' => HttpRequest::VERSION_11,
128130
'storeresponse' => true,
129131
'keepalive' => false,
130132
'outputstream' => false,
@@ -195,7 +197,7 @@ public function setConfig($config = array())
195197
*
196198
* @param Client\Adapter|string $adapter
197199
* @return Client
198-
* @throws \Zend\Http\Client\Exception
200+
* @throws Client\Exception\InvalidArgumentException
199201
*/
200202
public function setAdapter($adapter)
201203
{
@@ -247,7 +249,7 @@ public function setRequest(Request $request)
247249
public function getRequest()
248250
{
249251
if (empty($this->request)) {
250-
$this->request = new Request();
252+
$this->request = new HttpRequest();
251253
}
252254
return $this->request;
253255
}
@@ -272,7 +274,7 @@ public function setResponse(Response $response)
272274
public function getResponse()
273275
{
274276
if (empty($this->response)) {
275-
$this->response = new Response();
277+
$this->response = new HttpResponse();
276278
}
277279
return $this->response;
278280
}
@@ -352,8 +354,8 @@ public function setMethod($method)
352354
{
353355
$method = $this->getRequest()->setMethod($method)->getMethod();
354356

355-
if (($method == Request::METHOD_POST || $method == Request::METHOD_PUT ||
356-
$method == Request::METHOD_DELETE || $method == Request::METHOD_PATCH)
357+
if (($method == HttpRequest::METHOD_POST || $method == HttpRequest::METHOD_PUT ||
358+
$method == HttpRequest::METHOD_DELETE || $method == HttpRequest::METHOD_PATCH)
357359
&& empty($this->encType)) {
358360
$this->setEncType(self::ENC_URLENCODED);
359361
}
@@ -734,11 +736,11 @@ public function resetParameters($clearCookies = false)
734736
/**
735737
* Dispatch
736738
*
737-
* @param RequestDescription $request
738-
* @param ResponseDescription $response
739-
* @return ResponseDescription
739+
* @param Request $request
740+
* @param Response $response
741+
* @return Response
740742
*/
741-
public function dispatch(RequestDescription $request, ResponseDescription $response = null)
743+
public function dispatch(Request $request, Response $response = null)
742744
{
743745
$response = $this->send($request);
744746
return $response;
@@ -848,14 +850,14 @@ public function send(Request $request = null)
848850
}
849851
// cleanup the adapter
850852
$this->adapter->setOutputStream(null);
851-
$response = Response\Stream::fromStream($response, $stream);
853+
$response = HttpResponseStream::fromStream($response, $stream);
852854
$response->setStreamName($this->streamName);
853855
if (!is_string($this->config['outputstream'])) {
854856
// we used temp name, will need to clean up
855857
$response->setCleanup(true);
856858
}
857859
} else {
858-
$response = Response::fromString($response);
860+
$response = HttpResponse::fromString($response);
859861
}
860862

861863
// Get the cookies from response (if any)
@@ -878,7 +880,7 @@ public function send(Request $request = null)
878880
$response->getStatusCode() == 301))) {
879881

880882
$this->resetParameters();
881-
$this->setMethod(Request::METHOD_GET);
883+
$this->setMethod(HttpRequest::METHOD_GET);
882884
}
883885

884886
// If we got a well formed absolute URI
@@ -1018,7 +1020,7 @@ protected function prepareHeaders($body, $uri)
10181020
$headers = array();
10191021

10201022
// Set the host header
1021-
if ($this->config['httpversion'] == Request::VERSION_11) {
1023+
if ($this->config['httpversion'] == HttpRequest::VERSION_11) {
10221024
$host = $uri->getHost();
10231025
// If the port is not default, add it
10241026
if (!(($uri->getScheme() == 'http' && $uri->getPort() == 80) ||
@@ -1077,7 +1079,7 @@ protected function prepareHeaders($body, $uri)
10771079
$fstat = fstat($body);
10781080
$headers['Content-Length'] = $fstat['size'];
10791081
} else {
1080-
$headers['Content-Length'] = static::strlen($body);
1082+
$headers['Content-Length'] = strlen($body);
10811083
}
10821084
}
10831085

@@ -1204,7 +1206,7 @@ protected function detectFileMimeType($file)
12041206
public function encodeFormData($boundary, $name, $value, $filename = null, $headers = array())
12051207
{
12061208
$ret = "--{$boundary}\r\n" .
1207-
'Content-Disposition: form-data; name="' . $name .'"';
1209+
'Content-Disposition: form-data; name="' . $name . '"';
12081210

12091211
if ($filename) {
12101212
$ret .= '; filename="' . $filename . '"';
@@ -1215,7 +1217,6 @@ public function encodeFormData($boundary, $name, $value, $filename = null, $head
12151217
$ret .= "{$hname}: {$hvalue}\r\n";
12161218
}
12171219
$ret .= "\r\n";
1218-
12191220
$ret .= "{$value}\r\n";
12201221

12211222
return $ret;
@@ -1298,20 +1299,4 @@ protected function doRequest(Http $uri, $method, $secure = false, $headers = arr
12981299

12991300
return $this->adapter->read();
13001301
}
1301-
1302-
/**
1303-
* Returns length of binary string in bytes
1304-
*
1305-
* @param string $str
1306-
* @return int the string length
1307-
*/
1308-
static public function strlen($str)
1309-
{
1310-
if (function_exists('mb_internal_encoding') &&
1311-
(((int)ini_get('mbstring.func_overload')) & 2)) {
1312-
return mb_strlen($str, '8bit');
1313-
} else {
1314-
return strlen($str);
1315-
}
1316-
}
13171302
}

src/Client/Adapter/Socket.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,9 @@ public function connect($host, $port = 80, $secure = false)
207207

208208
$flags = STREAM_CLIENT_CONNECT;
209209
if ($this->config['persistent']) $flags |= STREAM_CLIENT_PERSISTENT;
210-
210+
211+
$errno = null;
212+
$errstr = '';
211213
$this->socket = @stream_socket_client($host . ':' . $port,
212214
$errno,
213215
$errstr,

src/Client/Cookies.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
namespace Zend\Http\Client;
2222

23-
use Zend\Stdlib\ParametersDescription,
23+
use Zend\Stdlib\ParametersInterface,
2424
Zend\Uri,
2525
Zend\Http\Header\Cookie,
2626
Zend\Http\Response;
@@ -48,7 +48,7 @@
4848
* @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
4949
* @license http://framework.zend.com/license/new-bsd New BSD License
5050
*/
51-
class Cookies //implements ParametersDescription
51+
class Cookies //implements ParametersInterface
5252
{
5353
/**
5454
* Return cookie(s) as a Zend\Http\Header\Cookie object

src/Cookies.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
namespace Zend\Http;
44

5-
use Zend\Stdlib\ParametersDescription,
6-
Zend\Uri,
5+
use Zend\Uri,
76
Zend\Http\Header\Cookie,
87
Zend\Http\Response;
98

0 commit comments

Comments
 (0)