Allow setting (int) 0 as Expires

ezimuel · ezimuel · commit aa4ee94280d8 · 2017-01-25T18:20:06.000+01:00
diff --git a/src/Header/Expires.php b/src/Header/Expires.php
@@ -32,7 +32,7 @@ public function getFieldName()
 
     public function setDate($date)
     {
-        if ($date === '0') {
+        if ($date === '0' || $date === 0) {
             $date = date(DATE_W3C, 0); // Thu, 01 Jan 1970 00:00:00 GMT
         }
         return parent::setDate($date);
diff --git a/test/Header/ExpiresTest.php b/test/Header/ExpiresTest.php
@@ -63,5 +63,9 @@ public function testExpiresSetToZero()
         $expires = new Expires();
         $expires->setDate('0');
         $this->assertEquals('Expires: Thu, 01 Jan 1970 00:00:00 GMT', $expires->toString());
+
+        $expires = new Expires();
+        $expires->setDate(0);
+        $this->assertEquals('Expires: Thu, 01 Jan 1970 00:00:00 GMT', $expires->toString());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function getFieldName()`
`32`	`32`
`33`	`33`	`public function setDate($date)`
`34`	`34`	`{`
`35`		`- if ($date === '0') {`
	`35`	`+ if ($date === '0' \|\| $date === 0) {`
`36`	`36`	`$date = date(DATE_W3C, 0); // Thu, 01 Jan 1970 00:00:00 GMT`
`37`	`37`	`}`
`38`	`38`	`return parent::setDate($date);`
Original file line number	Diff line number	Diff line change
`@@ -63,5 +63,9 @@ public function testExpiresSetToZero()`
`63`	`63`	`$expires = new Expires();`
`64`	`64`	`$expires->setDate('0');`
`65`	`65`	`$this->assertEquals('Expires: Thu, 01 Jan 1970 00:00:00 GMT', $expires->toString());`
	`66`	`+`
	`67`	`+ $expires = new Expires();`
	`68`	`+ $expires->setDate(0);`
	`69`	`+ $this->assertEquals('Expires: Thu, 01 Jan 1970 00:00:00 GMT', $expires->toString());`
`66`	`70`	`}`
`67`	`71`	`}`