Optional input without value are valid

Author: Maks3w

src/FileInput.php

@@ -119,6 +119,10 @@ public function isValid($context = null)
         $allowEmpty      = $this->allowEmpty();
         $continueIfEmpty = $this->continueIfEmpty();
 
+        if (! $hasValue && ! $required) {
+            return true;
+        }
+
         if (! $hasValue && $required && ! $this->hasFallback()) {
             $this->setErrorMessage('Value is required');
             return false;

src/Input.php

@@ -396,6 +396,10 @@ public function isValid($context = null)
             return true;
         }
 
+        if (! $hasValue && ! $required) {
+            return true;
+        }
+
         if (! $hasValue && $required) {
             $this->setErrorMessage('Value is required');
             return false;

test/InputTest.php

@@ -175,6 +175,25 @@ public function testRequiredWithoutFallbackAndValueNotSetThenFail()
         $this->assertEquals(['Value is required'], $input->getMessages(), 'getMessages() value not match');
     }
 
+    public function testNotRequiredWithoutFallbackAndValueNotSetThenIsValid()
+    {
+        $input = $this->input;
+        $input->setRequired(false);
+        $input->setAllowEmpty(false);
+        $input->setContinueIfEmpty(true);
+
+        // Validator should not to be called
+        $input->getValidatorChain()
+            ->attach($this->createValidatorMock(null, null))
+        ;
+        $this->assertTrue(
+            $input->isValid(),
+            'isValid() should be return always true when is not required, and no data is set. Detail: ' .
+            json_encode($input->getMessages())
+        );
+        $this->assertEquals([], $input->getMessages(), 'getMessages() should be empty because the input is valid');
+    }
+
     public function testNotEmptyValidatorNotInjectedIfContinueIfEmptyIsTrue()
     {
         $input = new Input('foo');