Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

[WIP] [ZF3] Refactor filter #112

Open
1 task
GeeH opened this issue Jun 28, 2016 · 1 comment
Open
1 task

[WIP] [ZF3] Refactor filter #112

GeeH opened this issue Jun 28, 2016 · 1 comment
Milestone

Comments

@GeeH
Copy link
Contributor

GeeH commented Jun 28, 2016

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/5097
User: @bakura10
Created On: 2013-09-09T19:01:52Z
Updated At: 2014-09-28T00:34:45Z
Body
As asked by @weierophinney on IRC, I should create the PR against develop.

So let's focus for now on Filter, this is the most advanced one and mostly done (just need to find a great way for some plugin manager), and some tests were already updated.

As a reminder, the Filter refactor is mostly:

  • Code cleaning (now, all filters accept the same options array, which allow to configure a filter)
  • Options are now underscore_separated
  • Some filters were remade

Comment

User: @bakura10
Created On: 2013-09-09T19:44:33Z
Updated At: 2013-09-09T19:44:33Z
Body
For people that want to help: I've spotted some test that say the test is invalid with PHP 5.4. Why? Does this means some thing can be removed in PHP 5.4?


Comment

User: @ThomasCantonnet
Created On: 2013-09-10T18:02:40Z
Updated At: 2013-09-10T18:06:48Z
Body
@bakura10 Although some have reported that iconv's //IGNORE option is broken on PHP 5.3.10 too, it seems that it's broken in PHP5.4 <= 5.4.6 (https://bugs.php.net/bug.php?id=61484). I don't know what the status on that issue is, but that might explain this test. It appears it's a glibc issue though, not sure how PHP versions affect this behaviour.

(Edit: my bad, it seems that it's just iconv that doesn't accept this //IGNORE option anymore and it hasn't been fixed in PHP 5.3, but it's been removed in 5.4. I guess we need to fix that filter.)

Seems like @Maks3w was the one who marked this test as incompatible (bakura10/zf2@ab87188) so he might answer you on the reasons :)


@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at laminas/laminas-inputfilter#4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants