Continued refactoring of Cache consumers

- Mostly testing
- Discovered some anomalies in PhpSerializer
- Discovered some issues with reference passing in Filesystem cache adapter
- Something is wrong with how the CLDR is using caching, which is
  affecting all Locale-based classes and their tests.
- Tags are NOT WORKING in the Filesystem adapter; cannot find items by
  tags. This is affecting the Paginator tests in particular, and
  potentially may be the problem with the CLDR usage as well.

Author: weierophinney

src/Adapter/PhpSerialize.php

@@ -40,7 +40,7 @@ class PhpSerialize extends AbstractAdapter
     /**
      * @var null|string Serialized boolean false value
      */
-    private static $_serializedFalse = null;
+    private static $serializedFalse = null;
 
     /**
      * Constructor
@@ -54,8 +54,8 @@ public function __construct($opts = array())
 
         // needed to check if a returned false is based on a serialize false
         // or based on failure (igbinary can overwrite [un]serialize functions)
-        if (self::$_serializedFalse === null) {
-            self::$_serializedFalse = serialize(false);
+        if (self::$serializedFalse === null) {
+            self::$serializedFalse = serialize(false);
         }
     }
 
@@ -69,11 +69,17 @@ public function __construct($opts = array())
      */
     public function serialize($value, array $opts = array())
     {
+        set_error_handler(function($errno, $errstr = '', $errfile = '', $errline = '') {
+            $message = sprintf(
+                'Error with serialize operation in %s:%d: %s',
+                $errfile,
+                $errline,
+                $errstr
+            );
+            throw new RuntimeException($message, $errno);
+        });
         $ret = serialize($value);
-        if ($ret === false) {
-            $lastErr = error_get_last();
-            throw new RuntimeException($lastErr['message']);
-        }
+        restore_error_handler();
         return $ret;
     }
 
@@ -88,11 +94,37 @@ public function serialize($value, array $opts = array())
      */
     public function unserialize($serialized, array $opts = array())
     {
-        $ret = @unserialize($serialized);
-        if ($ret === false && $serialized !== self::$_serializedFalse) {
-            $lastErr = error_get_last();
-            throw new RuntimeException($lastErr['message']);
+        if (!is_string($serialized)) {
+            // Must already be unserialized!
+            return $serialized;
+            throw new RuntimeException(sprintf(
+                '%s expects a serialized string argument; received "%s"',
+                __METHOD__,
+                (is_object($serialized) ? get_class($serialized) : gettype($serialized))
+            ));
+        }
+        if (!preg_match('/^((s|i|d|b|a|O|C):|N;)/', $serialized)) {
+            return $serialized;
         }
+
+        // If we have a serialized boolean false value, just return false; 
+        // prevents the unserialize handler from creating an error.
+        if ($serialized === self::$serializedFalse) {
+            return false;
+        }
+
+        set_error_handler(function($errno, $errstr = '', $errfile = '', $errline = '') use ($serialized) {
+            $message = sprintf(
+                'Error with unserialize operation in %s:%d: %s; (string: "%s")',
+                $errfile,
+                $errline,
+                $errstr,
+                $serialized
+            );
+            throw new RuntimeException($message, $errno);
+        }, E_NOTICE);
+        $ret = unserialize($serialized);
+        restore_error_handler();
         return $ret;
     }
 }

test/Adapter/PhpSerializeTest.php

@@ -139,11 +139,16 @@ public function testUnserializeObject()
         $this->assertEquals($expected, $data);
     }
 
-    public function testUnserialzeInvalid()
+    public function testUnserializingNonserializedStringReturnsItVerbatim()
     {
         $value = 'not a serialized string';
-        $this->setExpectedException('Zend\Serializer\Exception\RuntimeException', 'unserialize(): Error at offset 0 of 23 bytes');
-        $this->_adapter->unserialize($value);
+        $this->assertEquals($value, $this->_adapter->unserialize($value));
     }
 
+    public function testUnserializingInvalidStringRaisesException()
+    {
+        $value = 'a:foobar';
+        $this->setExpectedException('Zend\Serializer\Exception\RuntimeException');
+        $this->_adapter->unserialize($value);
+    }
 }