Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Provide support for PHP 7.2 #7

Closed
weierophinney opened this issue Apr 26, 2018 · 3 comments
Closed

Provide support for PHP 7.2 #7

weierophinney opened this issue Apr 26, 2018 · 3 comments
Labels
help wanted

Comments

@weierophinney
Copy link
Member

We need to require that PHP 7.2 tests pass (currently allows failure).
@hkulekci
Copy link

hkulekci commented Apr 27, 2018 •
edited
Loading

@weierophinney there is a mixed return type problem on https://github.com/zendframework/zend-xml2json/blob/master/src/Xml2Json.php#L78 I will send a PR but it will be BC break. What do you think?

@hkulekci
Copy link

And also phpunit result is successfull on php 7.2.4.

@michalbundyra michalbundyra mentioned this issue Apr 27, 2018
Closed
@weierophinney
Copy link
Member Author

there is a mixed return type problem on https://github.com/zendframework/zend-xml2json/blob/master/src/Xml2Json.php#L78

I'm sorry - what is the problem? Is it with the caller, in terms of not handling the two variants?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weierophinney @hkulekci