Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Commit c44c042

Browse files
committed
Merge branch 'master' of git://git.zendframework.com/zf
22 parents ca87540 + 3ed141c + a79cdbd + 73871a0 + 47d468d + 538d0f4 + b5ad75a + 2363c4f + 91c2337 + 04dcb58 + 906c7b6 + 0da7bb6 + 0270a77 + 6784c86 + 90d950a + 3b5ea7f + 339830e + b04f4d5 + 8da9d32 + 0e2a882 + f0829e4 + c66d3bb commit c44c042

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

test/ClientTest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testGettingDefaultHttpClient()
7373
{
7474
$xmlrpcClient = new Client('http://foo');
7575
$httpClient = $xmlrpcClient->getHttpClient();
76-
$this->assertType('Zend\\Http\\Client', $httpClient);
76+
$this->assertInstanceOf('Zend\\Http\\Client', $httpClient);
7777
$this->assertSame($httpClient, $xmlrpcClient->getHttpClient());
7878
}
7979

@@ -107,8 +107,8 @@ public function testLastRequestAndResponseAreSetAfterRpcMethodCall()
107107
$this->setServerResponseTo(true);
108108
$this->xmlrpcClient->call('foo');
109109

110-
$this->assertType('Zend\\XmlRpc\\Request', $this->xmlrpcClient->getLastRequest());
111-
$this->assertType('Zend\\XmlRpc\\Response', $this->xmlrpcClient->getLastResponse());
110+
$this->assertInstanceOf('Zend\\XmlRpc\\Request', $this->xmlrpcClient->getLastRequest());
111+
$this->assertInstanceOf('Zend\\XmlRpc\\Response', $this->xmlrpcClient->getLastResponse());
112112
}
113113

114114
public function testSuccessfulRpcMethodCallWithNoParameters()
@@ -336,8 +336,7 @@ public function testRpcMethodCallThrowsOnXmlRpcFault()
336336

337337
public function testGetProxyReturnsServerProxy()
338338
{
339-
$class = 'Zend\\XmlRpc\\Client\\ServerProxy';
340-
$this->assertType($class, $this->xmlrpcClient->getProxy());
339+
$this->assertInstanceOf('Zend\\XmlRpc\\Client\\ServerProxy', $this->xmlrpcClient->getProxy());
341340
}
342341

343342
public function testRpcMethodCallsThroughServerProxy()
@@ -390,7 +389,7 @@ public function testGettingDefaultIntrospector()
390389
{
391390
$xmlrpcClient = new Client('http://foo');
392391
$introspector = $xmlrpcClient->getIntrospector();
393-
$this->assertType('Zend\\XmlRpc\\Client\\ServerIntrospection', $introspector);
392+
$this->assertInstanceOf('Zend\\XmlRpc\\Client\\ServerIntrospection', $introspector);
394393
$this->assertSame($introspector, $xmlrpcClient->getIntrospector());
395394
}
396395

test/ResponseTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public function testGetFault()
107107
{
108108
$this->assertNull($this->_response->getFault());
109109
$this->_response->loadXml('foo');
110-
$this->assertType('Zend\\XmlRpc\\Fault', $this->_response->getFault());
110+
$this->assertInstanceOf('Zend\\XmlRpc\\Fault', $this->_response->getFault());
111111
}
112112

113113
/**

test/ServerTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public function testSettingClassWithArguments()
163163
$request = new Request();
164164
$request->setMethod('test.test4');
165165
$response = $this->_server->handle($request);
166-
$this->assertNotType('Zend\\XmlRpc\\Fault', $response);
166+
$this->assertNotInstanceOf('Zend\\XmlRpc\\Fault', $response);
167167
$this->assertSame(
168168
array('test1' => 'argv-argument',
169169
'test2' => null,
@@ -181,7 +181,7 @@ public function testSettingClassWithArgumentsOnlyPassingToConstructor()
181181
$request->setMethod('test.test4');
182182
$request->setParams(array('foo'));
183183
$response = $this->_server->handle($request);
184-
$this->assertNotType('Zend\\XmlRpc\\Fault', $response);
184+
$this->assertNotInstanceOf('Zend\\XmlRpc\\Fault', $response);
185185
$this->assertSame(array('test1' => 'a1', 'test2' => 'a2', 'arg' => array('foo')), $response->getReturnValue());
186186
}
187187

@@ -241,7 +241,7 @@ public function testCallingInvalidMethod()
241241
$request = new Request();
242242
$request->setMethod('invalid');
243243
$response = $this->_server->handle($request);
244-
$this->assertType('Zend\\XmlRpc\\Fault', $response);
244+
$this->assertInstanceOf('Zend\\XmlRpc\\Fault', $response);
245245
$this->assertSame('Method "invalid" does not exist', $response->getMessage());
246246
$this->assertSame(620, $response->getCode());
247247
}

test/ValueTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,7 @@ public function assertXmlRpcType($type, $object)
840840
$type = 'arrayValue';
841841
}
842842
$type = 'Zend\\XmlRpc\\Value\\' . ucfirst($type);
843-
$this->assertType($type, $object);
843+
$this->assertInstanceOf($type, $object);
844844
}
845845

846846
public function wrapXml($xml)

0 commit comments

Comments
 (0)