This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Initialize result message with empty string instead of null #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
Sep 17, 2018
- References the pull request - Makes it a fix instead of a change - Puts it in the correct changelog (1.3.1, not 1.3.2)
weierophinney
added a commit
that referenced
this pull request
Sep 17, 2018
weierophinney
added a commit
that referenced
this pull request
Sep 17, 2018
Forward port #94 Conflicts: CHANGELOG.md
|
Thanks, @meetmatt - merged, and released as 1.3.1. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to liip/LiipMonitorBundle#193
Provide a narrative description of what you are trying to accomplish:
Are you fixing a bug?
No, just an inconsistency between an interface and abstract implementation
Detail how the bug is invoked currently.
See #170 Strict null check of result message in console output liip/LiipMonitorBundle#193
Detail the original, incorrect behavior.
Namespace: ZendDiagnostics\Result
ResultInterface defines message property as a non-nullable string.
In AbstractResult it's defined/used as null|string.
Detail the new, expected behavior.
Initialize message as empty string.
Base your feature on the
masterbranch, and submit against that branch.Done.
Add a regression test that demonstrates the bug, and proves the fix.
It wasn't covered with test, but the change doesn't require test IMO.
Add a
CHANGELOG.mdentry for the fix.Done.
Are you creating a new feature?
No.
Is this related to quality assurance?
No.
Is this related to documentation?
No.