Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Updates needed for component selector #49

Open
2 of 6 tasks
froschdesign opened this issue Jun 15, 2018 · 5 comments
Open
2 of 6 tasks

Updates needed for component selector #49

froschdesign opened this issue Jun 15, 2018 · 5 comments
Assignees

Comments

@froschdesign
Copy link
Member

froschdesign commented Jun 15, 2018

Examples:

@froschdesign
Copy link
Member Author

Suggestion:

component-selector

  • fixes font size for component name (.choices__packagename)
  • updates background for headings / group names
  • adds shadow
  • updates placeholder in search field

ping @weierophinney, @thexpand

@thexpand
Copy link
Contributor

@froschdesign @weierophinney
Bigger font size for component name - OK
Shadow for the whole drop-down - OK
Shorter placeholder - Great

I just don't like the dark background of the headings. Seems too much.
I suggest using a smaller font size, but capital letters with a light gray background.
Here's a preview (combine this with the sticky headings from my PR):

screenshot from 2018-08-15 23-08-38

@froschdesign
Copy link
Member Author

@thexpand

... with a light gray background

The problem: this results in a poor contrast ratio.

@thexpand
Copy link
Contributor

thexpand commented Aug 15, 2018

@froschdesign That's why I added the capitalized letters :( I can't think of a better way to do this, unfortunately. By the way, higher contrast doesn't always mean better. Same goes to applying many colors, which I think is what we must escape from.

@froschdesign
Copy link
Member Author

@thexpand

That's why I added the capitalized letters

It's fine for short text, but if the text is longer and smaller, it will be harder to read.

By the way, higher contrast doesn't always mean better.

In this case it helps a lot. (compare the screenshots)

Same goes to applying many colors, which I think is what we must escape from.

Then we have no problem here! 😉 Because the entire documentation uses a minimal color palette. Colored are only the code examples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants