-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added abstract service factory for logger component to provide several loggers for application. #3930
Added abstract service factory for logger component to provide several loggers for application. #3930
Conversation
configuration. Change-Id: Ibd9309bf42c8992376849a1c5bbae05cd82e4c13
return true; | ||
|
||
} else { | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete the "else", finish with "return false" without else
method. Change-Id: Idf4802f8735a2333d927f5c6989e124c048e7854
@blanchonvincent done. |
@Stephanoff ok, now you must add unit tests with the PR |
Change-Id: Ibd0e492df076b801cb91078753bfe40bf77f63c0
@blanchonvincent Test case added. |
Change-Id: I8e342727e72db510a45b885ddb293ceef4590510
@Stephanoff This is brilliant. I'd like to see this approach adopted in more places, to be honest! |
Added abstract service factory for logger component to provide several loggers for application.
* @subpackage UnitTests | ||
* @group Zend_Log | ||
*/ | ||
class LoggerAbstractServiceFactoryTeset extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teset?
I have recently migrate to the 2.2.0 version of Zend Framework and I can't add a filters and formatter to the writer by using the configuration you give as example. (It would be unfortunate to be able to create loggers without being able to specify filters and formatter) |
Hi @steptom, Try to use 'log' section name instead of 'logger'. |
Hi @Stephanoff , In fact, the example has a lot of errors ;) |
…evelop-logger Added abstract service factory for logger component to provide several loggers for application.
Added support for multiple loggers in application.
Configuration should be like this: