This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed error in adapter paginator DbTableGateway #4169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing added as the table name. I added a third parameter to the ordination
| $select = $tableGateway->getSql()->select($where); | ||
| $select = $tableGateway->getSql()->select(); | ||
| if ($where) $select->where($where); | ||
| if ($order) $select->order($order); |
There was a problem hiding this comment.
Per the ZF coding standards, the two above lines need to be rewritten to use block form:
if ($where) {
$select->where($where);
}
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2013
- Conditionals require block format
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2013
ghost
assigned 
|
I made the requested changes on merge -- thanks for the patch! |
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
- Conditionals require block format
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
- per php-cs-fixer
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error in paging adapter DbTableGateway because the condition was being added as the table name.
I added a third parameter to the ordination