This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Use prefix in Logger abstract factory #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @category Zend | ||
| * @package Zend_Cache | ||
| * @subpackage UnitTests | ||
| * @group Zend_Cache |
- Allows having multiple cache objects by implementing an abstract factory. - When requesting a cache services, prefix with 'Cache\\', but configuration omits that prefix for brevity.
- To prevent collisions with other abstract factories, the logger abstract factory should require that, when requesting a service, the service name be prefixed. I chose "Logger", as that's the service type being requested. - This complements the approach in zendframework#4253 for cache objects. - Not a BC break, as the LoggerAbstractServiceFactory has not yet been released.
mwillbanks
pushed a commit
that referenced
this pull request
Apr 30, 2013
Created abstract factory for caches … - Allows having multiple cache objects by implementing an abstract factory. - When requesting a cache services, prefix with 'Cache\', but configuration omits that prefix for brevity. Force service prefix in LoggerAbstractServiceFactory … - To prevent collisions with other abstract factories, the logger abstract factory should require that, when requesting a service, the service name be prefixed. I chose Logger, as that's the service type being requested. - This complements the approach in #4253 for cache objects. - Not a BC break, as the LoggerAbstractServiceFactory has not yet been released. [#4254] Remove unneeded annotations … - per @samsonasik
mwillbanks
pushed a commit
that referenced
this pull request
Apr 30, 2013
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Created abstract factory for caches … - Allows having multiple cache objects by implementing an abstract factory. - When requesting a cache services, prefix with 'Cache\', but configuration omits that prefix for brevity. Force service prefix in LoggerAbstractServiceFactory … - To prevent collisions with other abstract factories, the logger abstract factory should require that, when requesting a service, the service name be prefixed. I chose Logger, as that's the service type being requested. - This complements the approach in zendframework/zf2zendframework/zf2#4253 for cache objects. - Not a BC break, as the LoggerAbstractServiceFactory has not yet been released. [zendframework/zendframework#4254] Remove unneeded annotations … - per @samsonasik
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force service prefix in LoggerAbstractServiceFactory
abstract factory should require that, when requesting a service, the
service name be prefixed. I chose "Logger", as that's the service type
being requested.
objects.
released.