Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Validator\Explode can take option validator as array #4260

Merged
merged 3 commits into from
May 1, 2013

Conversation

tolean
Copy link
Contributor

@tolean tolean commented Apr 18, 2013

No description provided.

use Zend\Stdlib\ArrayUtils;

class Explode extends AbstractValidator
class Explode extends AbstractValidator implements ServiceLocatorAwareInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good idea. If you were to use the ValidatorPluginManagerFactory to manage validators, implementing this interface will inject the application ServiceManager instance via the ServiceManagerAware initializer present in the MVC.

Instead, either create a "ValidatorPluginManagerAware" interface, or simply don't implement ServiceLocatorAwareInterface and implement the methods "setValidatorPluginManager" and "getValidatorPluginManager".

@ghost ghost assigned weierophinney May 1, 2013
weierophinney added a commit that referenced this pull request May 1, 2013
Validator\Explode can take option validator as array
weierophinney added a commit that referenced this pull request May 1, 2013
- per php-cs-fixer
weierophinney added a commit that referenced this pull request May 1, 2013
@weierophinney weierophinney merged commit a6dad77 into zendframework:develop May 1, 2013
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
Validator\Explode can take option validator as array
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants