This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix get with body in ClientStatic #4376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed ClientStatic to correctly accept a body. Before it was trying to call setBody which didn't exist. Unit test added. This change may be controversial as there is debate as to wether GET's should have a body or not. However, the documentation for this class says it is supported, so this fixes that broken functionality.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
May 2, 2013
Fix get with body in ClientStatic
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…ClientStatic-GET-with-body Fix get with body in ClientStatic
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ClientStatic to correctly accept a body. Before it was trying
to call setBody which didn't exist. Unit test added.
This change may be controversial as there is debate as to wether GET's
should have a body or not. However, the documentation for this class
says it is supported, so this fixes that broken functionality.