This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Segregated interfaces for Translator dependency of Validator component #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows validator component to use I18n as an optional dependency, by defining TranslatorInterface and TranslatorAwareInterface internally. - MVC component contains a bridge class that extends i18n Translator, implementing the validator TranslatorInterface
- that creates and returns the bridged interface
- To ensure the bridge version is used, if ever retrieved.
|
Every other factory within |
- from Zend\Mvc\I18n to Zend\Mvc\Service (per @akrabat)
- due to previous commit
|
@akrabat Good point. Done! |
This was referenced May 3, 2013
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces segregated interfaces for the Translator dependency inside the Validator component.
This allows us to remove the hard dependency on the i18n component, and allows usage of the Validator with other translator systems via interface implementation.
A bridge is provided in the
Zend\Mvc\I18nsubcomponent; additionally, the MVC uses a translator factory that consumes that bridge to ensure the translator service works with all components.