2.2.0RC1 Form\View\Helper\FormRow "partial view" messed up

[Slamdunk]

Something went wrong during some merge, and now these two feature

https://github.com/zendframework/zf2/blob/release-2.2.0rc1/library/Zend/Form/View/Helper/FormRow.php#L70-L78

Are orphans.

This commit introduced the new functionality ( without tests 😞 ) : 744cab1
And this one messed up stuffs during the merge: ee4e4fc

[weierophinney]

Can you provide a PR to fix this? I'm having issues trying to understand what needs to change...

[Slamdunk]

Me too 😄 I just found it while reading the source.
The main issue is that setPartial method was removed, so $partial is useless.

Btw, I'll try to understand what committer intended to do, and make a PR with tests to fix it...

[davidwindell]

Yeesh, how on earth did my partial stuff for FormRow end up in the repo O_o.

[weierophinney]

@davidwindell Does that mean #4412 is unnecessary, or that different changes need to be made, or ...?

[Slamdunk]

@weierophinney I don't know what @davidwindell meant to code, but I found the bug because I was looking exactly at that feature 😄

[davidwindell]

@weierophinney I'm happy for it to stay in, I need to review #4412 to see if it meets our requirements.

I had planned to PR the partial support in the future and didn't realise it had been merged.

[weierophinney]

@davidwindell Drop a note in #4412 when you've reviewed it, and let me know if/when it is ready.

Thanks!

[davidwindell]

@weierophinney will do ASAP