This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Edit config composer.json #4424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be a suggested, not required, dependency.
|
|
good to merge |
| @@ -16,6 +16,9 @@ | |||
| "php": ">=5.3.3", | |||
| "zendframework/zend-stdlib": "self.version" | |||
| }, | |||
| "suggest": { | |||
| "zendframework/zend-servicemanager": "self.version" | |||
There was a problem hiding this comment.
This should indicate not "self.version", but the name of the component, and why you might want to install it.
There was a problem hiding this comment.
I made the change on merge.
weierophinney
added a commit
that referenced
this pull request
May 6, 2013
Edit config composer.json
weierophinney
added a commit
that referenced
this pull request
May 6, 2013
- Use a description for the service-manager suggestion
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
Edit config composer.json
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
- Use a description for the service-manager suggestion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ServiceManager for ReaderPluginManager and WriterPluginManager