This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed unnecessary error rendering in form row helper. #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a unit test for this functionality. |
|
I didn't add any functionality, isn't this already covered by "testDoesNotRenderErrorsListIfSetToFalse"? |
|
@glen-84 That test was already passing, which means that we need to give it additional input covering the use case that would trigger the issue of errors rendering. |
|
@weierophinney How would I test if a method was invoked ($elementErrorsHelper->render()), is this even possible? My changes have no effect on the output of the helper. |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
May 9, 2013
…tion Fixed unnecessary error rendering in form row helper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.