This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Code: Docblock generates empty line under @tags if docblock was read from existing code #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existing code. it does not generate that line if docblock was created.
is in same namespace (or parent one). This also breaks code, as the absolute namespace doesnt have a \ in the beginning.
|
|
||
| if (substr($parameterType, 0, strlen($currentNamespace)) == $currentNamespace) { | ||
| $parameterType = substr($parameterType, strlen($currentNamespace)+1); | ||
| } |
There was a problem hiding this comment.
please fix the identation
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jun 11, 2013
Zend\Code: Docblock generates empty line under @tags if docblock was read from existing code
weierophinney
added a commit
that referenced
this pull request
Jun 11, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it does not generate that line if docblock was newly created.