This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Cache\Pattern\CallbackCache doesn't work with NULL #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented test case for zendframework#4629 - Used fix suggested in original report
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…lbacks - Implemented test case for zendframework/zendframework#4629 - Used fix suggested in original report
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zendframework/zf2/blob/master/library/Zend/Cache/Pattern/CallbackCache.php#L51
if (!isset($result[0])) {throw new Exception\RuntimeException("Invalid cached data for key '{$key}'");
}
The cache has been saved and loaded correct but this condition returns false because isset returns false on NULL - should be replaced by array_key_exists
;)