Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Change file mode from 644 to 755 templatemap_generator.php #4777

Closed
wants to merge 1 commit into from

Conversation

gag237
Copy link
Contributor

@gag237 gag237 commented Jul 3, 2013

No description provided.

@Bittarman
Copy link
Member

Why does the mode need changing? the general rule of thumb is that files should be 644 and directories 755

@gag237
Copy link
Contributor Author

gag237 commented Jul 3, 2013

  1. All other executable files in folder bin/ have 755
  2. Every time when I do composer {update|install} I give message: The package has modified files:
    M bin/templatemap_generator.php

diff --git a/bin/templatemap_generator.php b/bin/templatemap_generator.php
old mode 100644
new mode 100755

This changes do composer, when create links in vendor/bin, and it is true, file is executable.

@Maks3w
Copy link
Member

Maks3w commented Jul 12, 2013

It's reasonable because the PHP file has a shebang at the begin

@Maks3w
Copy link
Member

Maks3w commented Jul 12, 2013

This should be merged against master

weierophinney added a commit that referenced this pull request Jul 19, 2013
@ghost ghost assigned weierophinney Jul 19, 2013
@weierophinney
Copy link
Member

Cherry-picked into master and merged to develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants