You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah sure. Following this specification www.jsonrpc.org/specification the Error Code for a parse error should be -32700. This error should be sent when the JSON sent to the service is malformed. An example from the same page:
A request {"jsonrpc": "2.0", "method": "foobar, "params": "bar", "baz] should create this response: {"jsonrpc": "2.0", "error": {"code": -32700, "message": "Parse error"}, "id": null}
Before my PR the JSON parser just threw an unhandled exception which in this case is not desired and should be handled. Like the already existing isMethodError function I created an ìsParseError function so the Zend\Json\Server\Server can check in the Zend\Json\Server\Request object for it and create a proper Zend\Json\Server\Response.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #4817