This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
allow usage of validator and filter plugin managers in input filter factory if form manager injected #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory if form manager injected
|
please provide unit test. |
|
@richardjennings Does #4788 fix the issues you encountered as well? |
… from form manager
|
@weierophinney No. Inputs with an undefined type are created with a clone of the InputFilter Factory validator/filter chains which do not have access to plugin managers. I have provided an alternative fix, setting the plugin managers on the validator/filter chains if an InputFilterManager is provided with access to a ServiceLocatorInterface instance. |
…to add plugin managers to validator and filter chains
|
@richardjennings Okay -- can I get some unit tests from you, then, please? |
…nd inject validator and filter plugin managers into factory default filter and validator chains. Test setInputFilterPluginManager with and without ServiceLocator
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
allow usage of validator and filter plugin managers in input filter factory if form manager injected Conflicts: tests/ZendTest/InputFilter/FactoryTest.php
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…sue4801 allow usage of validator and filter plugin managers in input filter factory if form manager injected Conflicts: tests/ZendTest/InputFilter/FactoryTest.php
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #4801
Allow usage of Validator and Filter plugin managers in Input Filter factory if Form Manager Aware