Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Revise docblocks in Zend\Session\ContainerAbstractServiceFactory #4981

Conversation

pwarnock
Copy link
Contributor

Docblocks indicate usage of SessionConainer\ prefix

33  * Services use the prefix "SessionContainer\\":                                
34  *                                                                              
35  * <code>                                                                       
36  * $container = $services->get('SessionContainer\captcha');                     
37  * </code>                

and that normalizeContainerName strips off the prefix

141      *                                                                          
142      * Strips off the "SessionContainer\" prefix, and lowercases the name.      
143      *    

Docblocks revised to show sample configuration without stripping prefix.

@weierophinney
Copy link
Member

Actually... docblocks are legacy in this case; that was the original intent, but during review of the code, we decided to drop the prefixing.

So... I'll only accept this if you revert the code changes and instead remove the information in the docblocks.

@pwarnock
Copy link
Contributor Author

@weierophinney Thanks for the feedback.

weierophinney added a commit that referenced this pull request Aug 21, 2013
…iner

Revise docblocks in Zend\Session\ContainerAbstractServiceFactory
weierophinney added a commit that referenced this pull request Aug 21, 2013
@ghost ghost assigned weierophinney Aug 21, 2013
@pwarnock pwarnock deleted the hotfix/strip-off-session-container branch March 7, 2014 18:34
weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015
…fix/strip-off-session-container

Revise docblocks in Zend\Session\ContainerAbstractServiceFactory
weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants