This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Zend-Code] Fix Code Generation for non namespace classes #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add unit tests. |
|
Added unit tests before fixing issue. |
If using ClassGenerator for non namespace classes no methods are found inside classes, as the classname check fails always.
…pace and add backslash for non namespace classes For non-namespace classes this substr/strlen algorithm removed the first character of the classname. The slash is needed when generating namespace classes, which use non-namespace classes.
|
Same here, composer on travis not working atm -> failed |
weierophinney
added a commit
that referenced
this pull request
Aug 21, 2013
[Zend-Code] Fix Code Generation for non namespace classes
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassGenerator and ParameterGenerator had some issues with non-namespace classes.
The ClassGenerator tried to concatenate the namespace in the check if a reflectionmethod is from the same class.
The ParameterGenerator removed the first character for non-namespace classnames.
And there is a backslash missing for non-namespace classnames. As zf2 requires 5.3.3 this slash does not hurt anyone.