Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Db\TableGateway\Feature\FeatureSet::addFeature() at line 69 #4993

Closed
wja513 opened this issue Aug 21, 2013 · 5 comments
Closed

Zend\Db\TableGateway\Feature\FeatureSet::addFeature() at line 69 #4993

wja513 opened this issue Aug 21, 2013 · 5 comments
Assignees
Labels
Milestone

Comments

@wja513
Copy link

wja513 commented Aug 21, 2013

$feature->setTableGateway($feature);
May shoud be:
$feature->setTableGateway($this->tableGateway);
Is a simple mistake?

@ghost ghost assigned ralphschindler Aug 21, 2013
@samsonasik
Copy link
Contributor

@ThaDafinser AbstractFeature extends AbstractTableGateway, so it already right ?

@ramunasd
Copy link

@samsonasik no it's not, there still needs some check before assigning table gateway for feature instance

@samsonasik
Copy link
Contributor

@ThaDafinser @ramunasd I created PR #5868 for it, hope it fixes the issue ...

@ramunasd
Copy link

Can confirm it does. But checks looks too much excessive :)

@ralphschindler ralphschindler added this to the 2.2.6 milestone Mar 4, 2014
weierophinney added a commit that referenced this issue Mar 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants